Conversation
Contributor
Author
AlicanC
force-pushed
the
jc/rust-toolchain-toml
branch
from
5c7f92b to
ab39263
Compare
otrho
previously approved these changes
Nov 15, 2022
mohammadfawaz
previously approved these changes
Nov 15, 2022
AlicanC
force-pushed
the
jc/rust-toolchain-toml
branch
from
937041e to
39472ac
Compare
otrho
approved these changes
Nov 15, 2022
mohammadfawaz
approved these changes
Nov 15, 2022
Centril
approved these changes
Nov 18, 2022
Contributor
Author
|
I'm actually going to close this because I just couldn't find a convenient way of doing it. The action we currently use doesn't fully support our case and it's unmaintained so there's nothing we can do besides forking. There's an alternative but maintainer of that is refusing to implement support for the file. (This comment summarizes the situation well: actions-rs/toolchain#126 (comment)) I'll revisit if the situation changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toolchain file is used to pin a project to a certain version of the Rust toolchain.
We currently do not specify an actual version anywhere but just
stableso I have followed that, but pinning it to an actual version like1.65could prevent new Clippy lints, etc. breaking our CI process when there's a new release.Though, the file is useful even with just
stablesince it helps us clean the CI YAMLs.Note: The current format of this file is actually TOML, but the GH action we're using doesn't support it yet so I had to use the legacy format. (The GH action also seems to be unmaintained: actions-rs/toolchain#216)