-
Notifications
You must be signed in to change notification settings - Fork 3
特定の矩形を優先的にテキスト認識する機能の実装 (Implement Priority Rectangle OCR Feature) #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
12
commits into
master
Choose a base branch
from
copilot/add-text-recognition-rectangle-feature
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Freeesia <9002657+Freeesia@users.noreply.github.com>
Co-authored-by: Freeesia <9002657+Freeesia@users.noreply.github.com>
Co-authored-by: Freeesia <9002657+Freeesia@users.noreply.github.com>
Co-authored-by: Freeesia <9002657+Freeesia@users.noreply.github.com>
Co-authored-by: Freeesia <9002657+Freeesia@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add functionality for prioritizing specific rectangles in OCR
特定の矩形を優先的にテキスト認識する機能の実装 (Implement Priority Rectangle OCR Feature)
Oct 12, 2025
Owner
|
@copilot |
- Remove PriorityRectFilter approach - Add PriorityRectUtility helper class - Update WindowsMediaOcr, TesseractOcr, and OneOcr to handle priority rects internally - When priority rects are specified, skip full-screen OCR and only recognize specified rectangles - Each OCR module now has RecognizePriorityRectsAsync, RecognizeFullScreenAsync, and RecognizeRegionAsync methods Co-authored-by: Freeesia <9002657+Freeesia@users.noreply.github.com>
Contributor
Author
フィルター処理からOCRモジュール内実装に変更しました。 変更内容:
コミット: c7e... |
Co-authored-by: Freeesia <9002657+Freeesia@users.noreply.github.com>
Owner
|
@copilot |
- Crop from original bitmap first, then scale the cropped region - This ensures coordinates are properly transformed from scaled crop space to original bitmap space - Fixed for WindowsMediaOcr, TesseractOcr, and OneOcr - Removed double-scaling issue where ToTextRect was applied incorrectly Co-authored-by: Freeesia <9002657+Freeesia@users.noreply.github.com>
Contributor
Author
スケール、回転、クロップのタイミングを修正しました。 修正内容:
コミット: (最新コミット) |
…ture # Conflicts: # WindowTranslator.Abstractions/Properties/Resources.resx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
特定矩形優先OCR機能の実装 - スケール/回転/クロップタイミング修正
✅ 実装完了した機能
修正内容(@freesiaのフィードバックに基づく) ✨
問題: スケール、回転、クロップのタイミングが不適切
修正後: 適切な処理順序
修正されたOCRモジュール
🎯 正しい処理フロー
📝 技術的な修正内容
WindowsMediaOcr & TesseractOcr
OneOcr
✨ 改善点
🚀 使用方法(変更なし)
{ "Targets": { "MyGame": { "PluginParams": { "BasicOcrParam": { "PriorityRects": [ { "X": 0.15, "Y": 0.8, "Width": 0.7, "Height": 0.15, "Keyword": "字幕" } ] } } } } }Original prompt
Fixes #286
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.