More ergonomic handling of JSONL in dictinfo#198
Open
esimonov wants to merge 3 commits intoFreeLanguageTools:masterfrom
Open
More ergonomic handling of JSONL in dictinfo#198esimonov wants to merge 3 commits intoFreeLanguageTools:masterfrom
esimonov wants to merge 3 commits intoFreeLanguageTools:masterfrom
Conversation
Author
|
Hey team, can you review it, please? Without these changes, I'm unable to add nouns to my deck, as Wiktionary API is returning 403s. |
Contributor
|
Sorry seems like this slipped through the inbox. This is a good idea, but can you also make it handle the case if you give it a jsonl.{xz,gz,bz2}? |
Author
|
@1over137 Absolutely! I updated my branch. Please make sure that you agree with the new contents of |
Author
|
Ping, in case your inbox was too busy again :) |
Author
|
Weekly bump anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Read only the first line of the
.jsonlfile in order to determine itsdictinfo, instead of the entire file. That suffices due to JSONL specification:Why
English nouns Kaikki Wiktionary dump (~1.4GB in size) fails to import on my Windows PC (16 Gb RAM) with
MemoryError:Stack trace leads to the
dictinfofunction which loads the entire file into memory just for the sake of determining its format. Having that said,parseKaikkifunction that also processes JSONL files is already optimised with line-by-line reads.