Conversation
|
@carbonrobot I'd be very appreciative if you could take a look at this ❤️ |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ESLint plugin to support ESLint 9 and introduces flat config support while modernizing the codebase from Flow to TypeScript. The changes include migrating from CommonJS to ES modules, updating dependencies, and removing Flow type checking in favor of TypeScript.
- Migrates from Flow to TypeScript for type safety
- Adds ESLint 9 flat config support alongside existing configuration format
- Modernizes the build system from Babel to TypeScript compiler
Reviewed Changes
Copilot reviewed 62 out of 66 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates dependencies, changes build system from Babel to TypeScript, adds flat config exports |
| src/flat.ts | New flat config export for ESLint 9 compatibility |
| src/index.ts | Converts to ES modules and TypeScript, updates rule imports |
| src/rules/*.ts | Converts all rules from Flow to TypeScript with updated type definitions |
| tests/*.test.ts | Updates test files to use new language options mapper for ESLint 9 |
| config files | Replaces ESLint legacy config with flat config, removes Babel/Flow configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rejas
left a comment
There was a problem hiding this comment.
I would like to see this PR being followed thorugh so that our app an get checked.
Alas it seems this doesnt work yet 100% (or I need some help building it)
| "type": "git", | ||
| "url": "https://github.com/FormidableLabs/eslint-plugin-react-native-a11y" | ||
| }, | ||
| "main": "dist/index.js", |
There was a problem hiding this comment.
when I build this pr I get some files in dist/src, but not this index file...
| "main": "dist/index.js", | ||
| "exports": { | ||
| ".": { | ||
| "types": "./dist/index.d.ts", |
There was a problem hiding this comment.
I dont see any types when building the package here
Description
This PR aims to update the plugin dependencies and stack in order to introduce ESLint 9 Flat Config.
Fixes #166
Type of Change
How Has This Been Tested?
No new features were added. Existing tests are passing
Checklist: (Feel free to delete this section upon completion)