This repository was archived by the owner on Apr 2, 2021. It is now read-only.
Update README to follow Circle CI 2.0 configuration#34
Open
yo7 wants to merge 1 commit intoFormidableLabs:masterfrom
Open
Update README to follow Circle CI 2.0 configuration#34yo7 wants to merge 1 commit intoFormidableLabs:masterfrom
yo7 wants to merge 1 commit intoFormidableLabs:masterfrom
Conversation
drorasaf
reviewed
Jul 16, 2018
|
|
||
| steps: | ||
| - checkout | ||
| - run: yarn install |
There was a problem hiding this comment.
what about caching the yarn and maybe add names for the steps?
Author
There was a problem hiding this comment.
I've added minimal steps like it currently is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #33.
The configuration file I updated is minimal and not including steps to cache dependencies, just to keep the readme simple.
I don't think the current default
testcommand increate-react-native-appruns Jest in--watchmode. So I removed that part.