Skip to content

pavol_DBUpdate_fix #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Palo124 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pavol_DBUpdate_fix #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions forloop_modules/function_handlers/database_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,18 +1154,12 @@ def _get_sql_update_statements(self, db_instance, dbtable, set_value,
set_column_name, where_value, where_column_name,
where_operator):

quote = db_instance.identifier_quote # Gets the correct quote (` or ")

# This function correctly adds single quotes for strings but not numbers.
set_value_sql = _parse_float_sql(set_value)
where_value_sql = _parse_float_sql(where_value)

# Correctly build the SET statement, quoting ONLY the column name.
set_statement = f"{quote}{set_column_name}{quote} = {set_value_sql}"
set_statement = f"{set_column_name} = {set_value_sql}"

# Correctly build the WHERE statement, quoting ONLY the column name.
# DEPENDENCY in dbhydra update
where_statement = f"{quote}{where_column_name}{quote} {where_operator} {where_value_sql}"
where_statement = f"{where_column_name} {where_operator} {where_value_sql}"

return set_statement, where_statement

Expand Down