Skip to content

Daniel/format ncrb [Only merge after mergin #107] #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YoungMasterGandalf wants to merge 12 commits into
base: main-prompt-poc
Choose a base branch
from
Open

Daniel/format ncrb [Only merge after mergin #107] #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7a19beb
Add httpx.Response to http_client methods type hints
YoungMasterGandalf Nov 17, 2024
beef2f2
Format and update imports in ncrb
YoungMasterGandalf Nov 17, 2024
51cd342
Format 'resources' variable in ncrb
YoungMasterGandalf Nov 17, 2024
988c7b9
Format DB_API_BODY_TEMPLATE in ncrb
YoungMasterGandalf Nov 17, 2024
28061ff
Improve set_stored_project_uid_and_pipeline_uid_to_factory_payload do…
YoungMasterGandalf Nov 17, 2024
151e4a6
Add docstrings and type-hints to ncrb factory functions
YoungMasterGandalf Nov 17, 2024
3f2a370
Remove old legacy code from ncrb
YoungMasterGandalf Nov 17, 2024
eaae0e6
Add type-hints to ncrb functions
YoungMasterGandalf Nov 17, 2024
6bb091c
Fix httpx responses' reason
YoungMasterGandalf Nov 21, 2024
dda0676
Update docstrings and type-hints of new and update factory funcs
YoungMasterGandalf Nov 21, 2024
f7e511e
Ruff format ncrb
YoungMasterGandalf Nov 21, 2024
f92c20e
Remove redundant comments
YoungMasterGandalf Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion forloop_modules/function_handlers/browser_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ def direct_execute(self, elements, objective):
redis_action_key = redis_config.SCRAPING_ACTION_KEY_TEMPLATE.format(pipeline_uid=aet.active_pipeline_uid)
kv_redis.set(redis_action_key, result)
else:
raise CriticalPipelineError(response.reason)
raise CriticalPipelineError(response.reason_phrase)


browser_handlers_dict = {
Expand Down
2 changes: 1 addition & 1 deletion forloop_modules/function_handlers/database_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def get_all_databases_in_project():
response = ncrb.get_all_databases()

if response.status_code != 200:
raise Exception(f'Error {response.status_code}: {response.reason}.')
raise Exception(f'Error {response.status_code}: {response.reason_phrase}.')

databases = response.json().get("result", {}).get("databases")
project_databases = [database for database in databases if database["project_uid"] == aet.project_uid]
Expand Down
2 changes: 1 addition & 1 deletion forloop_modules/queries/context_request_backend_auxiliary_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def get_and_subset_requested_objects(ncrb_function, func_args:Optional[list]=Non
result = filter_items_by_project_uid(result)
return result
else:
flog.warning(f'Status code {response.status_code}: {response.reason}')
flog.warning(f'Status code {response.status_code}: {response.reason_phrase}')

def filter_items_by_project_uid(items:list):
user_items = items
Expand Down
Loading