More relics

[Nekaida]

This PR adds stats for the following relics:

Dolly's Mirror: Card duplicated (for run history mostly)
Empty Cage: Removed cards
Bag of Marbles/Red Mask/Twisted Funnel: Artifact removed and Vulnerable/Weak/Poison applied

[beeyee0401]

@ForgottenArbiter wondering if this can get checked out and published to the Steam workshop if possible. Planning on using some of this data if it exists in the run files.

[ForgottenArbiter]

Hey, sorry! I'm going to try and make a push to get a new version of Relic Stats out in the next couple of weeks, so I should be pretty active on this stuff if you're still interested. Generally, these ideas look good to me. I just had a few comments/suggestions:

First, for Bag of Marbles, Red Mask, and Twisted Funnel, I've been trying to avoid implementing stats in this way, because it's very fragile with respect to relics that other mods might implement. In this case, things may not be accurate if a custom relic has an atBattleStart trigger that applies a debuff. I have generally been handling this by adding extra action(s) to the action queue. In the case of Bag of Marbles, you could write a patch to add a custom action to the action queue that will execute right before each ApplyPowerAction, and possibly another action right after each ApplyPowerAction to compare the amount of Vulnerable that was actually applied and the amount of Artifact that was actually removed. Relics like Pocketwatch are implemented in a similar way. If you want to copy them, it would probably be the most robust. But just having an InsertPatch that counts the Artifact probably would be fine, as well. If you don't have time to do this, I can make the changes myself, too.

Also, for those relics like Bag of Marbles, I've gone back and forth on the stats to display. They feel like combat stats, where I would show stats per floor/combat, but that gets a bit messy if you have two different stats to display. The main comparison here would be Gremlin Horn, where I display both energy and cards per combat separately. Would that make sense here? For example, we could have, for Bag of Marbles:

Vulnerable applied:
Artifact removed:
Vulnerable per combat:
Artifact removed per combat:

The thing is, it gets kind of awkward in terms of both length of text and number of lines of text. It might be cleaner to just leave it without any sort of "per combat" or "per turn" numbers.

Another consideration is that I'm finally going to look at estimating "damage dealt" by relics like bag of marbles in the next couple of weeks, so if that works out in a satisfactory way, there really would be an estimated damage dealt/prevented stat for all of these relics, and this wouldn't be too much of a concern. If you have any thoughts about all of this, I'd be happy to hear them.

[Nekaida]

Hi, thanks for the reply! I totally agree that the implementation of the artifact-removing relics isn't very robust. I'm not sure if I will find the time to pick this up in the next days, but I would like to, especially knowing about the possibility to use Pocket Watch as a template.