-
Notifications
You must be signed in to change notification settings - Fork 231
Strings builder dsl #2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Strings builder dsl #2016
Conversation
FooIbar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't use data class as we want multiple layers of fallbacks, e.g. zh-HK -> zh-TW -> en.
We can use data class.copy, but it seems data class hits jvm max method limit. |
|
@FooIbar reimplemented, PTAL. Pros: cleanest way for translators to add new strings |
|
dex size decrease for 100KB as well |
FooIbar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the way. How do the translators check for missing translations? They could just remove the by EnStrings before.
I don't think translators will use IDE or check for compiler message. |
No description provided.