(fix) Avoid crash when there is no theme defined.#63
Merged
harvestcore merged 3 commits intodevelopfrom Feb 12, 2026
Merged
Conversation
jogawebb
approved these changes
Feb 12, 2026
jogawebb
left a comment
jogawebb
left a comment
There was a problem hiding this comment.
Looks good for catching the absence of theme1.xml, but in the long run we should probably look into whether or not we should just always create it.
| try { | ||
| theme = await ThemeXml.fromArchive(archive); | ||
| } catch (_) { | ||
| // no-op |
There was a problem hiding this comment.
Maybe a warning or something similar?
Author
There was a problem hiding this comment.
I could add a console.warn or something similar here, but it won't be captured.
harvestcore
force-pushed
the
optional-theme
branch
from
825510e to
8c6aff5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the title says 🙂
The theme is optional and, unless specified,
docxmldoes not include it by default.