Merged
Conversation
This commit adds Sendable conformance to various value types throughout the codebase to ensure thread safety in concurrent environments. Changes include: - Core types: ParameterRange, PixelAspectRatio, Geometry, OvalBrush - All Filter structs (12 filters) - Error types: EngineRuntimeError, EditingStackError - UI configuration types: ClassicImageEditOptions, ClassicImageEditStyle - Editing types: EditingCrop, ImageTool These changes enable safer usage of these types across different actors and threads without risk of data races. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sendableconformance to various value types throughout the codebaseChanges
Core Types
ParameterRange<T, Target>- Generic parameter range typePixelAspectRatio- Aspect ratio structGeometry- Geometry calculation enumOvalBrush- Oval brush configuration structFilter Types (12 filters)
FilterBrightness,FilterContrast,FilterSaturationFilterExposure,FilterHighlights,FilterShadowsFilterTemperature,FilterSharpen,FilterGaussianBlurFilterUnsharpMask,FilterVignette,FilterFadeError Types
EngineRuntimeError- Engine runtime errorsEditingStackError- Editing stack errorsUI Configuration Types
ClassicImageEditOptionsand nested structsClassicImageEditStyleand nested structsEditing Types
EditingCrop- Crop information structEditingCrop.Rotation- Rotation angle enumImageTool- Image processing tool enumTest Plan
🤖 Generated with Claude Code