Skip to content

Migrate to DownloadHandler API for Vaadin 25 compatibility #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mlopezFC wants to merge 5 commits into
base: master
Choose a base branch
from

refactor: extract common logic in a separate class

e608b7c
Select commit
Loading
Failed to load commit list.
Draft

Migrate to DownloadHandler API for Vaadin 25 compatibility #189

refactor: extract common logic in a separate class
e608b7c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 26, 2025 in 17s

Quality Gate failed

Failed conditions
8.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 319 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZq84AEOvK_9d0Mfzo2Z&open=AZq84AEOvK_9d0Mfzo2Z&pullRequest=189

Check warning on line 375 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZq84AEOvK_9d0Mfzo2d&open=AZq84AEOvK_9d0Mfzo2d&pullRequest=189

Check warning on line 402 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZq84AEOvK_9d0Mfzo2f&open=AZq84AEOvK_9d0Mfzo2f&pullRequest=189

Check warning on line 361 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZq84AEOvK_9d0Mfzo2c&open=AZq84AEOvK_9d0Mfzo2c&pullRequest=189

Check warning on line 388 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZq84AEOvK_9d0Mfzo2e&open=AZq84AEOvK_9d0Mfzo2e&pullRequest=189

Check failure on line 81 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "com.flowingcode.vaadin.addons.gridexporter.ConcurrentOperationBase" for "MAX_COST". 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZq9YdmAZqhFnrDkgnFT&open=AZq9YdmAZqhFnrDkgnFT&pullRequest=189

Check warning on line 24 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/ConcurrentDownloadHandler.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'com.vaadin.flow.server.VaadinSession'. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZrBFODLZzgyS1d0Prb_&open=AZrBFODLZzgyS1d0Prb_&pullRequest=189

Check failure on line 84 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use static access with "com.flowingcode.vaadin.addons.gridexporter.ConcurrentOperationBase" for "MIN_COST". 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZq9YdmAZqhFnrDkgnFU&open=AZq9YdmAZqhFnrDkgnFU&pullRequest=189

Check warning on line 347 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZq84AEOvK_9d0Mfzo2b&open=AZq84AEOvK_9d0Mfzo2b&pullRequest=189

Check failure on line 1043 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove usage of generic wildcard type. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZrBFOArZzgyS1d0Prb-&open=AZrBFOArZzgyS1d0Prb-&pullRequest=189

Check warning on line 333 in src/main/java/com/flowingcode/vaadin/addons/gridexporter/GridExporter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Do not forget to remove this deprecated code someday. 

See more on https://sonarcloud.io/project/issues?id=FlowingCode_GridExporterAddon&issues=AZq84AEOvK_9d0Mfzo2a&open=AZq84AEOvK_9d0Mfzo2a&pullRequest=189
View more details on SonarQubeCloud