remove(demo): remove LegacyDemo

[javier-godoy]

Summary by CodeRabbit

• Chores
  • Removed a legacy demo and its helper renderer from the test/demo suite.
  • Updated demo registrations to no longer include the legacy demo.
  • Cleaned up associated test/demo artifacts.

[coderabbitai]

Walkthrough

The pull request removes two legacy demo classes from test sources and updates the Demo constructor to stop registering the removed LegacyDemo; remaining demo registrations are unchanged.

Changes

Cohort / File(s)	Summary
Removed legacy demo files src/test/java/com/flowingcode/vaadin/addons/demo/LegacyDemo.java, src/test/java/com/flowingcode/vaadin/addons/demo/LegacyDemoHelperRenderer.java	Deleted two public classes: LegacyDemo (Vaadin Div component annotated for demo metadata) and LegacyDemoHelperRenderer (implementation of DemoHelperRenderer producing helper content).
Updated demo registration src/test/java/com/flowingcode/vaadin/addons/demo/Demo.java	Removed initialization/registration of LegacyDemo from the Demo constructor; constructor now registers only SampleDemo, SampleDemoDefault, SampleDemoHighlight, AdHocDemo, MultiSourceDemo, and SourcePositionDemo.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

Areas to check:

• Any test references or build config that expected LegacyDemo or LegacyDemoHelperRenderer.
• Demo discovery/registration mechanisms to ensure no runtime lookup expects the deleted classes.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'remove(demo): remove LegacyDemo' accurately reflects the main changes in the pull request, which involve removing the LegacyDemo class, LegacyDemoHelperRenderer class, and related initialization code from the demo module.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch remove-legacy-demo

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b75d1eb and eb634a3.

📒 Files selected for processing (3)

• src/test/java/com/flowingcode/vaadin/addons/demo/Demo.java (0 hunks)
• src/test/java/com/flowingcode/vaadin/addons/demo/LegacyDemo.java (0 hunks)
• src/test/java/com/flowingcode/vaadin/addons/demo/LegacyDemoHelperRenderer.java (0 hunks)

💤 Files with no reviewable changes (3)

• src/test/java/com/flowingcode/vaadin/addons/demo/LegacyDemo.java
• src/test/java/com/flowingcode/vaadin/addons/demo/LegacyDemoHelperRenderer.java
• src/test/java/com/flowingcode/vaadin/addons/demo/Demo.java

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud