Skip to content

refactor: rename switchSourcePosition method and refactor: rewrite toggleSourcePosition using setSourcePosition #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paodb merged 4 commits into from
Nov 10, 2025
Merged

refactor: rename switchSourcePosition method and refactor: rewrite toggleSourcePosition using setSourcePosition #124

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6a54207
style: remove unused imports
javier-godoy Nov 6, 2025
be4f397
style: remove unnecessary 'this' qualifier
javier-godoy Nov 6, 2025
f03f35e
refactor: rename switchSourcePosition method
javier-godoy Nov 7, 2025
c209bb6
refactor: rewrite toggleSourcePosition using setSourcePosition
javier-godoy Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 18 additions & 24 deletions src/main/java/com/flowingcode/vaadin/addons/demo/SplitLayoutDemo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,12 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import org.apache.commons.lang3.StringUtils;

@SuppressWarnings("serial")
class SplitLayoutDemo extends Composite<SplitLayout> {

private MultiSourceCodeViewer code;
private Component demo;
private SourcePosition sourcePosition;

public SplitLayoutDemo(Component demo, String sourceUrl, SourcePosition sourcePosition) {
Expand All @@ -50,35 +48,31 @@ public SplitLayoutDemo(Component demo, List<SourceCodeTab> tabs) {
properties.put("flow", Version.getFullVersion());

code = new MultiSourceCodeViewer(tabs, properties);

this.sourcePosition = code.getSourcePosition();
switch (this.sourcePosition) {
case PRIMARY:
getContent().addToPrimary(code);
getContent().addToSecondary(demo);
break;
case SECONDARY:
default:
getContent().addToPrimary(demo);
getContent().addToSecondary(code);
}
this.demo = demo;
setSourcePosition(code.getSourcePosition());

getContent().setSizeFull();
}

public void switchSourcePosition(SourcePosition position) {
if (!this.sourcePosition.equals(position)) {
toggleSourcePosition();
private void setSourcePosition(SourcePosition position) {
if (!position.equals(sourcePosition)) {
getContent().removeAll();
switch (position) {
case PRIMARY:
getContent().addToPrimary(code);
getContent().addToSecondary(demo);
break;
case SECONDARY:
default:
getContent().addToPrimary(demo);
getContent().addToSecondary(code);
}
sourcePosition = position;
}
}

public void toggleSourcePosition() {
Component primary = getContent().getPrimaryComponent();
Component secondary = getContent().getSecondaryComponent();
getContent().removeAll();
getContent().addToPrimary(secondary);
getContent().addToSecondary(primary);
this.sourcePosition = this.sourcePosition.toggle();
setSourcePosition(sourcePosition.toggle());
}

public void setOrientation(Orientation o) {
Expand Down