Merged
Conversation
joepavitt
approved these changes
Nov 22, 2024
Contributor
|
This conflict should get resolved once #1463 is merged, so will wait for Steve's eyes on it before moving forward with this one. |
# Conflicts: # ui/src/widgets/ui-text/UIText.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The sanetization of injected html into the ui-text node (see other PR) seems to remove a bit too much attributes, because the
targetattribute of hyperlinks is also removed.The DOMPurify library offers two ways to customize which attributes should be allowed:
ALLOWED_ATTRcan be used to replace the entire list of default allowed attributes. Which imho seems to be a bit too invasive.ADD_ATTRcan be used to retain the default list of allowed attributes and to add a few more.I have used the latter option to add allow the
linkattribute. Of course extra attributes can be added in the future if necessary.The result:
Related Issue(s)
Closes #1464
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel