Skip to content

Conversation

@FlorianPfaff
Copy link
Owner

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 17, 2023

MegaLinter analysis: Error

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 5 0 0 0.13s
✅ COPYPASTE jscpd yes no no 5.47s
✅ JSON prettier 2 0 0 0 0.59s
✅ JSON v8r 2 0 0 3.89s
✅ MARKDOWN markdownlint 1 0 0 0 0.72s
✅ MARKDOWN markdown-table-formatter 1 0 0 0 0.26s
✅ PYTHON bandit 246 0 0 3.23s
✅ PYTHON black 246 3 0 0 6.1s
❌ PYTHON flake8 246 7 0 1.62s
✅ PYTHON isort 246 3 0 0 0.5s
✅ PYTHON mypy 246 0 0 4.01s
❌ PYTHON pylint 246 16 0 59.89s
❌ PYTHON ruff 246 3 6 0 0.12s
✅ REPOSITORY gitleaks yes no no 4.3s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY secretlint yes no no 4.13s
✅ REPOSITORY syft yes no no 1.38s
✅ REPOSITORY trivy-sbom yes no no 1.1s
✅ REPOSITORY trufflehog yes no no 10.9s
✅ YAML prettier 9 1 0 0 0.62s
✅ YAML v8r 9 0 0 6.78s
✅ YAML yamllint 9 0 0 0.5s

Detailed Issues

❌ PYTHON / flake8 - 7 errors
pyrecest/filters/hyperhemispherical_grid_filter.py:44:18: E711 comparison to None should be 'if cond is None:'
pyrecest/filters/hyperhemispherical_grid_filter.py:45:13: F841 local variable 'measNoise' is assigned to but never used
pyrecest/filters/hyperhemispherical_grid_filter.py:45:25: F821 undefined name 'measNoise'
pyrecest/filters/hyperhemispherical_grid_filter.py:85:30: F821 undefined name 'AbstractDistribution'
pyrecest/filters/hyperhemispherical_grid_filter.py:127:181: E501 line too long (186 > 180 characters)
pyrecest/tests/filters/test_hyperhemispherical_grid_filter.py:113:9: F821 undefined name 'test_predict_converges_to_uniform'
pyrecest/tests/filters/test_hyperhemispherical_grid_filter.py:116:9: F821 undefined name 'test_predict_converges_to_uniform'
❌ PYTHON / pylint - 16 errors
************* Module pyrecest.filters.hyperhemispherical_grid_filter
pyrecest/filters/hyperhemispherical_grid_filter.py:3:0: E0401: Unable to import 'pyrecest.filters.abstract_grid_filter' (import-error)
pyrecest/filters/hyperhemispherical_grid_filter.py:5:0: E0401: Unable to import 'pyrecest.distributions.hypersphere_subset.hyperhemispherical_grid_distribution' (import-error)
pyrecest/filters/hyperhemispherical_grid_filter.py:5:0: E0611: No name 'hyperhemispherical_grid_distribution' in module 'pyrecest.distributions.hypersphere_subset' (no-name-in-module)
pyrecest/filters/hyperhemispherical_grid_filter.py:6:0: E0401: Unable to import 'pyrecest.distributions.conditional.sd_half_cond_sd_half_grid_distribution' (import-error)
pyrecest/filters/hyperhemispherical_grid_filter.py:6:0: E0611: No name 'sd_half_cond_sd_half_grid_distribution' in module 'pyrecest.distributions.conditional' (no-name-in-module)
pyrecest/filters/hyperhemispherical_grid_filter.py:54:12: E1101: Class 'BinghamDistribution' has no 'fit' member (no-member)
pyrecest/filters/hyperhemispherical_grid_filter.py:62:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
pyrecest/filters/hyperhemispherical_grid_filter.py:62:29: E0602: Undefined variable 'AbstractDistribution' (undefined-variable)
************* Module pyrecest.tests.filters.test_hyperhemispherical_grid_filter
pyrecest/tests/filters/test_hyperhemispherical_grid_filter.py:4:0: E0401: Unable to import 'pyrecest.distributions.hypersphere_subset.hyperhemispherical_grid_distribution' (import-error)
pyrecest/tests/filters/test_hyperhemispherical_grid_filter.py:4:0: E0611: No name 'hyperhemispherical_grid_distribution' in module 'pyrecest.distributions.hypersphere_subset' (no-name-in-module)
pyrecest/tests/filters/test_hyperhemispherical_grid_filter.py:5:0: E0401: Unable to import 'pyrecest.distributions.conditional.sd_half_cond_sd_half_grid_distribution' (import-error)
pyrecest/tests/filters/test_hyperhemispherical_grid_filter.py:5:0: E0611: No name 'sd_half_cond_sd_half_grid_distribution' in module 'pyrecest.distributions.conditional' (no-name-in-module)
pyrecest/tests/filters/test_hyperhemispherical_grid_filter.py:67:8: E0601: Using variable 'test_predict_converges_to_uniform' before assignment (used-before-assignment)
pyrecest/tests/filters/test_hyperhemispherical_grid_filter.py:69:8: R0913: Too many arguments (7/6) (too-many-arguments)
pyrecest/tests/filters/test_hyperhemispherical_grid_filter.py:69:8: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
pyrecest/tests/filters/test_hyperhemispherical_grid_filter.py:69:8: R0914: Too many local variables (16/15) (too-many-locals)

-----------------------------------
Your code has been rated at 9.93/10
❌ PYTHON / ruff - 6 errors
E711 Comparison to `None` should be `cond is None`
  --> pyrecest/filters/hyperhemispherical_grid_filter.py:48:21
   |
46 |     def update_identity(self, meas_noise, z=None):
47 |         assert isinstance(meas_noise, AbstractHyperhemisphericalDistribution)
48 |         if not z == None:
   |                     ^^^^
49 |             measNoise = measNoise.setMode(z)
50 |         curr_grid = self.gd.get_grid()
   |
help: Replace with `cond is None`

F841 Local variable `measNoise` is assigned to but never used
  --> pyrecest/filters/hyperhemispherical_grid_filter.py:49:13
   |
47 |         assert isinstance(meas_noise, AbstractHyperhemisphericalDistribution)
48 |         if not z == None:
49 |             measNoise = measNoise.setMode(z)
   |             ^^^^^^^^^
50 |         curr_grid = self.gd.get_grid()
51 |         self.gd = self.gd.multiply(
   |
help: Remove assignment to unused variable `measNoise`

F821 Undefined name `measNoise`
  --> pyrecest/filters/hyperhemispherical_grid_filter.py:49:25
   |
47 |         assert isinstance(meas_noise, AbstractHyperhemisphericalDistribution)
48 |         if not z == None:
49 |             measNoise = measNoise.setMode(z)
   |                         ^^^^^^^^^
50 |         curr_grid = self.gd.get_grid()
51 |         self.gd = self.gd.multiply(
   |

F821 Undefined name `AbstractDistribution`
  --> pyrecest/filters/hyperhemispherical_grid_filter.py:89:30
   |
87 |     @staticmethod
88 |     def sys_noise_to_transition_density(d_sys, no_grid_points):
89 |         if isinstance(d_sys, AbstractDistribution):
   |                              ^^^^^^^^^^^^^^^^^^^^
90 |             if isinstance(
91 |                 d_sys, (HyperhemisphericalWatsonDistribution, WatsonDistribution)
   |

F821 Undefined name `test_predict_converges_to_uniform`
   --> pyrecest/tests/filters/test_hyperhemispherical_grid_filter.py:114:9
    |
113 |     def test_predict_converges_to_uniform_S2_S3(self):
114 |         test_predict_converges_to_uniform(
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
115 |             3, 501, [-2, -1, 0], 3, 5e-5, "eq_point_set_symm", 6
116 |         )
    |

F821 Undefined name `test_predict_converges_to_uniform`
   --> pyrecest/tests/filters/test_hyperhemispherical_grid_filter.py:117:9
    |
115 |             3, 501, [-2, -1, 0], 3, 5e-5, "eq_point_set_symm", 6
116 |         )
117 |         test_predict_converges_to_uniform(
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
118 |             4, 1001, [-2, -1, -0.5, 0], 5, 1e-3, "eq_point_set", 8
119 |         )
    |

Found 6 errors.
No fixes available (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.1.0 --custom-flavor-setup --custom-flavor-linters PYTHON_PYLINT,PYTHON_BLACK,PYTHON_FLAKE8,PYTHON_ISORT,PYTHON_BANDIT,PYTHON_MYPY,PYTHON_RUFF,ACTION_ACTIONLINT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security

@github-actions
Copy link

github-actions bot commented Sep 17, 2023

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit ce27644.

♻️ This comment has been updated with latest results.

@FlorianPfaff FlorianPfaff force-pushed the feature/HyperhemisphericalGridFilter branch from d58c919 to 6fb02b1 Compare September 17, 2023 19:50
@FlorianPfaff FlorianPfaff force-pushed the main branch 3 times, most recently from 9b9c4f0 to a089dfc Compare September 29, 2023 12:45
@FlorianPfaff FlorianPfaff force-pushed the feature/HyperhemisphericalGridFilter branch from 6fb02b1 to 6c9d859 Compare January 19, 2024 21:15
@FlorianPfaff FlorianPfaff force-pushed the main branch 5 times, most recently from 022c55e to bb9ada8 Compare June 14, 2024 20:52
@FlorianPfaff FlorianPfaff force-pushed the feature/HyperhemisphericalGridFilter branch from 6c9d859 to ce27644 Compare November 14, 2025 17:28
@FlorianPfaff FlorianPfaff force-pushed the main branch 3 times, most recently from cbbee9b to 22baafb Compare December 1, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants