-
Notifications
You must be signed in to change notification settings - Fork 5
Clean Anchors #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Clean Anchors #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 0c3ef44 Author: Matt Hall <5151457+mattEhall@users.noreply.github.com> Date: Wed Jul 23 11:41:24 2025 -0600 Removing HAMS BEM files and what causes them: - removing examples 03 BEM folder created by RAFT runs. - changing RAFT YAML PotMods from True to False to avoid issue in future. commit 7828a9f Author: Moreno <fmoreno@nrel.gov> Date: Fri Jul 18 09:50:56 2025 -0600 Depreciated function trapz needs to be reused due to uncompatibility with CI tests commit 33edd4b Author: Moreno <fmoreno@nrel.gov> Date: Fri Jul 18 09:40:11 2025 -0600 support_soils linked connected commit 0941863 Author: Moreno <fmoreno@nrel.gov> Date: Fri Jul 18 09:36:12 2025 -0600 Depreciated function trapz needs to be reused due to uncompatibility with CI tests commit b4dea97 Author: Moreno <fmoreno@nrel.gov> Date: Thu Jul 17 16:16:45 2025 -0600 Change order of the CI tests: pytest + example_driver.py commit 30b2ca5 Author: Moreno <fmoreno@nrel.gov> Date: Thu Jul 17 15:37:25 2025 -0600 Changes on the yaml file to include new soil structure commit 4e0866e Author: Moreno <fmoreno@nrel.gov> Date: Thu Jul 17 11:42:37 2025 -0600 Removed anchor tension limit exception commit 7de4650 Author: Moreno <fmoreno@nrel.gov> Date: Wed Jul 16 11:26:31 2025 -0600 Update FAModel_anchors: new anchor scripts, updated RAFT BEM inputs, suction pile improvements commit 0d75993 Author: Moreno <fmoreno@nrel.gov> Date: Tue Jul 8 13:05:36 2025 -0600 Remove outdated 04_Anchors examples after migrating to 05_Anchors commit b8dbd3f Merge: 4383c4c 831d651 Author: Moreno <fmoreno@nrel.gov> Date: Tue Jul 8 13:04:43 2025 -0600 Merge upstream changes; keep local anchor.py, store upstream version as backup commit 4383c4c Author: Moreno <fmoreno@nrel.gov> Date: Tue Jul 8 12:16:53 2025 -0600 WIP: Local development progress before merging upstream FAModel commit 834999b Author: Moreno <fmoreno@nrel.gov> Date: Mon Jun 23 11:15:04 2025 -0600 Merge upstream/main into FAModel_anchors with local enhancements, including update to capacity_suction.py commit f149d96 Merge: 6030d1c 12ce2a3 Author: Moreno <fmoreno@nrel.gov> Date: Mon Jun 23 11:09:12 2025 -0600 Merge remote-tracking branch 'upstream/main' into sync/upstream-2025-06-23 commit 6030d1c Author: Moreno <fmoreno@nrel.gov> Date: Mon Jun 23 10:59:03 2025 -0600 WIP: custom changes before upstream sync commit 883b024 Author: Moreno <fmoreno@nrel.gov> Date: Wed Jun 18 16:30:20 2025 -0600 Major refactor of anchor module: removed legacy map files, added new anchor types and updated capacities commit 66e4bc0 Author: Moreno <fmoreno@nrel.gov> Date: Fri Jun 13 16:00:51 2025 -0600 feat: update anchor capacity scripts and add suction example notebook
To start, I created a new "display" variable that can toggle on/off print statements--in anchor.py and capacity function files--to make the output file clear to read - NOTE: This was only done for suction piles and dandg piles. The display parameter will have to be called from the other anchor type capacity function scripts, which I did not prioritize right now Second, I ran into problems with anchor.dd['type'] values not being exact strings of 'suction', 'dandg', etc. - I corrected the type values in my Project on my front-end, but also added a check in Anchor.__init__ to make sure the type values are exactly what they should be - In makeMoorPyAnchor, it references MoorPy.getPointProps['AnchorProps'], which contain cost information for certain types of anchors. If the anchor type does not exist in getPointProps (e.g., 'dandg'), then it defaults to a suction pile getSizeAnchor - Implemented functionality to support safety factors on different components (includes Hm, Vm, and UC right now) - Updated a lot of if statements to check for the anchType just in case the string is something different but includes the main anchor type name - Added a constraint function for the design variable bounds, since COBYLA does not recognize bounds - Moved the code that updated the anchor design dictionary and recalculated the capacity to the first constraint function, since with COBYLA, the constraints are evaluated first, and this led to UC's that didn't correspond - Added a check to the dandg (and driven/helical) sections to ensure the L/D constraints were being met - - However, the UC constraints weren't being met; this may require a reevaluation of the methods that we're using for design, since we're not using COBYLA for these anymore Updated getSizeAnchor2 to work with what I had too capacity_suction bounds upgrade for design iterations that have a L/D greater than 6
…apacity model examples updates
lsirkis
reviewed
Aug 22, 2025
examples/example_anchors.py - should this file remain? famodel/anchors/anchor.py - does this work - is there unused code to clear out after the merge? famodel/geography.py - does this work after the merge? - may need to update input file directories tests/test_anchors.py - merge conflicts left that need resolution
GitHub CI should run example.
-- no major changes to functionality -- tests and examples will not work at this time, this is a WIP for the merge
…up!!!! -- WIP merge -- !!!! geography.py still has unresolved conflicts because this needs to be discussed with team (Felipe and Stein) to ensure this is done properly !!!! -- added small change to anchor.py to make anchor names not case-sensitive and print out anchor type name in error message if not part of anchor -- small change to examples/OntologySample200m.yaml to make anchor type names match new system (suction_pile -> suction) -- pushing this now so we can track progress towards final merge.
-- remove extra getSizeAnchor functions into temp storage in AnchorDesign_temp.py (new file, could eventually turn into a full anchor design script) -- small bug fixes in examples -- resolve remaining conflicts in geography.py
-- removed MBL and unit_cost from anchor.cost dictionary to match methodology of other component cost dicts.
lsirkis
reviewed
Nov 7, 2025
- plus remove extraneous example_anchors.py, update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a number of upgrades and new features developed under FAModel_anchors, focused on the anchor module and its integration with the overall FAModel workflow. Key additions include:
examples/05_AnchorsAnchorclass modifications - ongoing processgetSizeAnchormethods within theAnchorclassThese updates are intended to improve the flexibility and reliability of anchor design workflows. All changes have been tested locally using the available test suite but there might be some incompatibilities under the radar that might raise with users feedback.
commit 0c3ef44
Author: Matt Hall 5151457+mattEhall@users.noreply.github.com
Date: Wed Jul 23 11:41:24 2025 -0600
commit 7828a9f
Author: Moreno fmoreno@nrel.gov
Date: Fri Jul 18 09:50:56 2025 -0600
commit 33edd4b
Author: Moreno fmoreno@nrel.gov
Date: Fri Jul 18 09:40:11 2025 -0600
commit 0941863
Author: Moreno fmoreno@nrel.gov
Date: Fri Jul 18 09:36:12 2025 -0600
commit b4dea97
Author: Moreno fmoreno@nrel.gov
Date: Thu Jul 17 16:16:45 2025 -0600
commit 30b2ca5
Author: Moreno fmoreno@nrel.gov
Date: Thu Jul 17 15:37:25 2025 -0600
commit 4e0866e
Author: Moreno fmoreno@nrel.gov
Date: Thu Jul 17 11:42:37 2025 -0600
commit 7de4650
Author: Moreno fmoreno@nrel.gov
Date: Wed Jul 16 11:26:31 2025 -0600
commit 0d75993
Author: Moreno fmoreno@nrel.gov
Date: Tue Jul 8 13:05:36 2025 -0600
commit b8dbd3f
Merge: 4383c4c 831d651
Author: Moreno fmoreno@nrel.gov
Date: Tue Jul 8 13:04:43 2025 -0600
commit 4383c4c
Author: Moreno fmoreno@nrel.gov
Date: Tue Jul 8 12:16:53 2025 -0600
commit 834999b
Author: Moreno fmoreno@nrel.gov
Date: Mon Jun 23 11:15:04 2025 -0600
commit f149d96
Merge: 6030d1c 12ce2a3
Author: Moreno fmoreno@nrel.gov
Date: Mon Jun 23 11:09:12 2025 -0600
commit 6030d1c
Author: Moreno fmoreno@nrel.gov
Date: Mon Jun 23 10:59:03 2025 -0600
commit 883b024
Author: Moreno fmoreno@nrel.gov
Date: Wed Jun 18 16:30:20 2025 -0600
commit 66e4bc0
Author: Moreno fmoreno@nrel.gov
Date: Fri Jun 13 16:00:51 2025 -0600