Fix for #9: Javascript callback not call Android callback#10
Open
MatejMainus wants to merge 1 commit intoFlipboard:masterfrom
MatejMainus:StrayJSCallbacks
Open
Fix for #9: Javascript callback not call Android callback#10MatejMainus wants to merge 1 commit intoFlipboard:masterfrom MatejMainus:StrayJSCallbacks
MatejMainus wants to merge 1 commit intoFlipboard:masterfrom
MatejMainus:StrayJSCallbacks
Conversation
Fixed bug when javascript callback didnt call Android callback Patch: Callback wraper is now not registered as WeakReference. Javascript Callback wrapper has optional attribute keepAlive that mean: "Keep this callback because javascript can call him again". Default behaviour (Standard callback) is remove callback after use.
MatejMainus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug when javascript callback didnt call Android callback
Patch:
Callback wraper is now not registered as WeakReference. Javascript Callback wrapper has optional attribute keepAlive that
mean: "Keep this callback because javascript can call him again".
Default behaviour (Standard callback) is remove callback after use.