Skip to content

Don't generate 3 band resistor when it can't represent the value #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bond-009 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Don't generate 3 band resistor when it can't represent the value #35

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75b1326
Don't generate 3 band resistor when it can't represent the value
Bond-009 Jul 23, 2025
23e2937
Make accuracy check more generic
Bond-009 Jul 23, 2025
e567e7c
Add comment
Bond-009 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions LabelGenerator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,9 @@ def draw_resistor_colorcode(
num_codes: int,
tolerance_value: Optional[float],
) -> None:
# Only display resistors that can accurately represent the given value
if value.ohms_val % (10 ** (4 - num_codes)):
Copy link
Owner

@Finomnis Finomnis Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a comment before this if? Like # Only display resistors that can accurately represent the given value.

return

resistance_values: List[int] = []
for i in range(num_codes-1):
Expand Down
Loading