Optimize student queries with QueryDSL to reduce N+1 queries #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Student lookup operations were executing multiple separate queries (N+1 problem), fetching user, student info, fixed rooms, and attendance data in separate database round trips.
Changes
Added
StudentQueryRepositorywith QueryDSL methods that fetch all student data in single queries using joins:findAllInfoByStatusAndRoomAndType()- fetch by room and attendance typefindAllInfoByStatusAndGradeAndCls()- fetch by grade and classfindAllInfoByRoomTypeStatusAndRole()- fetch by room type and statusRefactored service layer to use new repository methods:
GetStudentServicenow callsfindAllInfoByStatusAndRoomAndType()andfindAllInfoByStatusAndGradeAndCls()GetNotAttendedStudentServiceleverages same methods with status filteringQuery Example
Before: Multiple queries executed per student
After: Single query with joins
queryFactory.from(userEntity) .innerJoin(studentInfoEntity).on(...) .innerJoin(fixedRoomEntity).on(...) .leftJoin(attendanceEntity).on(...) .transform(groupBy(userEntity.id).list(...))The new queries use
groupBywithtransform()to aggregate related entities and return aList<StudentQueryDto>containing all necessary data from a single database query.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.