[UI-Filecoin][UXIT-3825] Create BreakoutContainer component #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
vercel
bot
temporarily deployed
to
Preview – filecoin-foundation-uxit
vercel
bot
temporarily deployed
to
Preview – filecoin-foundation-site
mirhamasala
force-pushed
the
mm/ui-filecoin-breakout-container
branch
from
56de895 to
f22f1e4
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds a new
BreakoutContainercomponent that allows content (primarily tables) to break out of the standardContainermax-width constraint while maintaining consistent padding with the rest of the layout.This solves the problem where certain content types (like wide data tables) feel cramped within the 1440px container but still need to maintain visual alignment with other page content.
Design Decision: We considered adding a
fullWidthprop toPageSectionandContainer, but this approach became messy becauseSectionContentis also involved in these layouts. SinceSectionContentcan accept multiple children, it would be difficult to selectively apply full-width to specific children while keeping the title/description constrained. TheBreakoutContainerwrapper approach is cleaner—it's explicit, flexible, and doesn't complicate our core layout components with conditional logic.🛠️ Key Changes
BreakoutContainercomponent toContainer.tsxmax-w-[1440px]constraintpx-6 md:px-15) across all viewports