Skip to content

Conversation

@woensug-choi
Copy link
Collaborator

A draft we all can work on.

I've added my parts including the ones that are not on Trello.

@bsb808
Copy link
Contributor

bsb808 commented Feb 25, 2022

Wow - thank you @woensug-choi and @j-herman for getting a head start on this!

I'll take the lead on it and will ask folks for details were needed. I'll ask @mabelzhang for a review once we are close and then merge it when I tag the release.

@bsb808 bsb808 self-assigned this Feb 25, 2022
@bsb808 bsb808 added this to the 4.3.0 milestone Feb 25, 2022
@mabelzhang
Copy link
Contributor

@bsb808 Do we want to merge this PR in the other repo before tagging the release? Field-Robotics-Lab/nps_uw_multibeam_sonar#38

I've just approved it. If we want, I can merge that one, otherwise we can wait for Woensug's daytime. How do we do the joint release - will that repo be tagged separately anyway?

@bsb808
Copy link
Contributor

bsb808 commented Feb 25, 2022

@mabelzhang Doing them at the same time would be ideal. Go ahead and merge Field-Robotics-Lab/nps_uw_multibeam_sonar#38

@mabelzhang
Copy link
Contributor

Field-Robotics-Lab/nps_uw_multibeam_sonar#38 has been merged

Copy link
Contributor

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some URLs

Pending: #207
If it gets merged, should add to changelog.
Although, the relevant wiki page has already been added under "Coming Soon." So maybe the PR could get added there too.

j-herman and others added 3 commits February 25, 2022 15:40
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
@j-herman
Copy link
Contributor

Fixed some URLs

Pending: #207 If it gets merged, should add to changelog. Although, the relevant wiki page has already been added under "Coming Soon." So maybe the PR could get added there too.

Just moved both to the changelog, since we found the problem! Hoping I didn't just jinx it, but 207 should be merged shortly.

@mabelzhang
Copy link
Contributor

I'm glad I'm not the only one who believes in jinxing.

bsb808 and others added 7 commits February 25, 2022 16:47
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
@bsb808
Copy link
Contributor

bsb808 commented Feb 26, 2022

@mabelzhang - good to merge?

@bsb808 bsb808 merged commit 3507bcc into master Feb 26, 2022
@bsb808 bsb808 deleted the release_4_3_0_changelog branch February 26, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants