Skip to content

Update AbstractContainer get method return type #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdiazromeral wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update AbstractContainer get method return type #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pypendency/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class AbstractContainer(ABC):
def set(self, identifier: str, service: object) -> None: pass

@abstractmethod
def get(self, identifier: str) -> Optional[object]: pass
def get(self, identifier: str) -> Any: pass

@abstractmethod
def has(self, identifier: str) -> bool: pass
Expand Down Expand Up @@ -76,7 +76,7 @@ def set(self, identifier: str, service: object, tags: Optional[Set[Tag]] = None)
def has(self, identifier: str) -> bool:
return identifier in self._service_mapping

def get(self, identifier: str) -> Optional[object]:
def get(self, identifier: str) -> Any:
if self.is_resolved() is False:
self.resolve()

Expand All @@ -93,7 +93,7 @@ def set_definition(self, definition: Definition) -> None:
definition.identifier: definition
})

def _do_get(self, identifier: str) -> Optional[object]:
def _do_get(self, identifier: str) -> Any:
empty = object()

service = self._service_mapping.get(identifier, empty)
Expand Down