Tidy dependencies #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
via a gitsubmodule at https://github.com/FastFilter/xor_singleheader.git rather than an older and local copy of that lib
one dependency per line to make things clearer dependcies for each target made more complete by generating with g++ -M -MF - init submodules for deps from either foreign repo
which also means we are now only including one xorfilter.h from one repo change Makefile to reflect this
no impact on Makefile here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up dependencies as discussed in
#9
Make the demo repo FilterPassword depend on the up2date library:
https://github.com/FastFilter/xor_singleheader
Plus some tidy ups to Makefile and #includes to make dependencies clearer.