Only update Christmas and Halloween if the configuration for them is set to true. #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only change Halloween to true when the configuration is set to true, and the same goes for Christmas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraria ends holidays at the start of a new day by default (except when it's that time of the year in real life), so it isn't necessary to turn off the holidays and it makes it less mod compatible. Some mods may want to activate Christmas or Halloween at a certain time or with an item, but this mod will shut it off right after it does. I think ending the holiday every
PostWorldUpdate()would also cancel the vanilla mechanic of starting a Holiday after beating the Pumpkin Moon or Frost Moon.