Skip to content

Remove the values from the AttributeError message #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baldurh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove the values from the AttributeError message #1126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions factory/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,8 +366,9 @@ def __getattr__(self, name):
return value
else:
raise AttributeError(
"The parameter %r is unknown. Evaluated attributes are %r, "
"definitions are %r." % (name, self.__values, self.__declarations))
"The parameter %r is unknown. Available attributes are: %s."
% (name, ", ".join(list(self.__declarations)))
)

def __setattr__(self, name, value):
"""Prevent setting attributes once __init__ is done."""
Expand Down
7 changes: 6 additions & 1 deletion tests/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,14 @@ class Meta:
model = TestObject

one = declarations.LazyAttribute(lambda a: a.does_not_exist)
two = 2

with self.assertRaises(AttributeError):
with self.assertRaises(AttributeError) as exc:
TestObjectFactory()
self.assertEqual(
str(exc.exception),
"The parameter 'does_not_exist' is unknown. Available attributes are: one, two.",
)

def test_inheritance_with_sequence(self):
"""Tests that sequence IDs are shared between parent and son."""
Expand Down