Ensure the lengthId attribute is set on fields of type data #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fields of type data are supposed to be defined in orchestra XML with an attribute lengthId that points to the tag containing its length as value. The attribute lengthId was dropped when building the xml orchestra from the markdown and could be seen missing on expected tag (example: on field 96 RawData)
test that defining a tag of type data ensure he lengthId attribute is added to the xml file
Upgrade jackson version to remove vulnerability in dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX tags of type data are supposed to be always immediately preceded by a tag containing their length to ensure proper parsing of FIX message. Fields of type data are missing the the lengthId attribute in the XML Orchestra file when generated from a markdown. This change ensure the lengthId is always populated of the field type is "data" and contains the immediately preceding tag id
#79