Open
Conversation
Closed
yifeili98
changed the title
kis87988
requested review from
AmberWow123,
ak840206,
biankaiwen111,
emilylxf and
hk-mp5a3
hk-mp5a3
reviewed
Apr 15, 2020
api/fhda_api_1.1.yaml
Outdated
| 400: | ||
| description: bad input parameter | ||
|
|
||
| /add_course: |
There was a problem hiding this comment.
Would it be better to use /api/course/add?
Member
Author
There was a problem hiding this comment.
Good point, will work on it in next commit
api/fhda_api_1.1.yaml
Outdated
| description: Secured Admin-only calls | ||
|
|
||
| paths: | ||
| /course_by_quarter: |
There was a problem hiding this comment.
similarly, would /api/course/get be better? and you can use something like /api/course/get?quarter=2020winter
api/fhda_api_1.1.yaml
Outdated
| 400: | ||
| description: bad input parameter | ||
|
|
||
| /course_by_quarter_and_dept: |
There was a problem hiding this comment.
e.g. /api/course/get?quarter=2020winter&dept=MATH
hk-mp5a3
reviewed
May 20, 2020
api/fhda_api_1.1.yaml
Outdated
|
|
||
|
|
||
| #################Instructor OPERATIONS########################### | ||
| /instructor/get: |
There was a problem hiding this comment.
Would it be better to have a URL as “/instructor”, the method as "GET"(for retrieving), "POST"(for adding), etc?
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relating to issue #2