Correct operator precedence #1571
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FCare
reviewed
Oct 23, 2024
In the previous version, != took precedence over ^ so that (((*A)>>11)&0x1) != 0 was evaluated first and then xored with the left hand side. Here I remove all the unnecessary parens except the ones suggested by GCC -Wparentheses. And add the parens that are actually needed in order to evaluate !=0 last.
pstef
force-pushed
the
operator-precedence
branch
from
c68a715 to
c316b37
Compare
Owner
|
I do not know exactly which flag or version of gcc has this issue, i did not dig in the debugging of gcc. Kronos is using gcc since the beginning and inherited lot of those unary operator code from yabause. We found during fixing that unary usage requires a lot of care with parenthesis. I am not open to remove any parenthesis here. Just add a new one since it may introduce regressions more than fixes. I agree it is not really readable but it works. If clang is complaining for the equality, just add one parenthesis, not more. Thanks |
Author
|
I've found the flag and corrected the commit, GCC should not be complaining. Would it be ok for you as it is now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is untested but it should work :)
In the previous version, != took precedence over ^ so that (((*A)>>11)&0x1) != 0 was evaluated first and then xored with the left hand side.
Here I remove all the unnecessary parens except the ones suggested by GCC -Wparentheses. And add the parens that are actually needed in order to evaluate !=0 last.