Skip to content

Conversation

@knirirr
Copy link
Contributor

@knirirr knirirr commented Dec 3, 2025

This deals with #2673.
As far as I can tell the added files should be OK when upgraded to Vue3.

Looks like reindexing the dev server is necessary. I'm doing that now.

Copy link
Contributor

@allysonlister allysonlister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah did I not notice the typo where it said 'globally unique' too much?
image

Also, can I ignore this:
image

I can't tell from the code, but will these options allow a multi-select in the advanced search (e.g., select both persistent and resolvable?)

@allysonlister
Copy link
Contributor

(I'll check the netlify build)

@allysonlister
Copy link
Contributor

Ah I see now - they are radio buttons as individual elements - that's great!

Copy link
Contributor

@ramGranell ramGranell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search works properly, my only suggestion is to change the font size of the chips or the background colour as I think they are not easy to read (please compare them with the other chips of subjects, domains and taxonomy)

@knirirr
Copy link
Contributor Author

knirirr commented Dec 3, 2025

Thanks. I picked that size specifically (being aware of other chips) as I have no problems with readability and prefer them to fit into the line of text.
How desperate are you for them to be changed? Do you have any thoughts @allysonlister ?

@ramGranell
Copy link
Contributor

Thanks. I picked that size specifically (being aware of other chips) as I have no problems with readability and prefer them to fit into the line of text. How desperate are you for them to be changed? Do you have any thoughts @allysonlister ?

In the previous version there was an upper-case text "GUPRI" but now Ihave problems to read the lower-case white font over light blue in a small font. Anyway, it would be great to ask an expert of user interface.

@knirirr
Copy link
Contributor Author

knirirr commented Dec 3, 2025

@ramGranell in that case I suggest that you create a PR adjusting these labels to your preference; we can then be sure that you find them sufficiently easy to read.

@allysonlister
Copy link
Contributor

Please can you use this order for the three fields in the edit screen and the view screen?

  1. globally unique
  2. persistent
  3. resolvable

@knirirr knirirr merged commit 34aaa6c into dev Dec 4, 2025
15 checks passed
@knirirr knirirr deleted the new_search_fields_2673 branch December 4, 2025 17:00
@knirirr knirirr restored the new_search_fields_2673 branch December 4, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants