-
Notifications
You must be signed in to change notification settings - Fork 4
New search fields 2673 #2675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New search fields 2673 #2675
Conversation
…haring.github.io into new_search_fields_2673
allysonlister
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
(I'll check the netlify build) |
|
Ah I see now - they are radio buttons as individual elements - that's great! |
ramGranell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The search works properly, my only suggestion is to change the font size of the chips or the background colour as I think they are not easy to read (please compare them with the other chips of subjects, domains and taxonomy)
|
Thanks. I picked that size specifically (being aware of other chips) as I have no problems with readability and prefer them to fit into the line of text. |
In the previous version there was an upper-case text "GUPRI" but now Ihave problems to read the lower-case white font over light blue in a small font. Anyway, it would be great to ask an expert of user interface. |
|
@ramGranell in that case I suggest that you create a PR adjusting these labels to your preference; we can then be sure that you find them sufficiently easy to read. |
|
Please can you use this order for the three fields in the edit screen and the view screen?
|


This deals with #2673.
As far as I can tell the added files should be OK when upgraded to Vue3.
Looks like reindexing the dev server is necessary. I'm doing that now.