Clean up test annotations#817
Draft
dennisvang wants to merge 5 commits intofeature/634-boostrapping-fdpfrom
Draft
Clean up test annotations#817dennisvang wants to merge 5 commits intofeature/634-boostrapping-fdpfrom
dennisvang wants to merge 5 commits intofeature/634-boostrapping-fdpfrom
Conversation
…on-overriding The @componentscan is redundant when using @SpringBootApplication and even causes problems as described in #816. Althoug it cannot be verified, it looks like allow-bean-definition-overriding=true was added to mitigate these problems, as both were added in the same large commit.
this is redundant because @SpringBootTest already configures MVC, and the global annotation prevented us from creating test slices using e.g. @DataJpaTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #816 (see issue for detailed description)