Functions listHosts/getHostById/deleteHostById working#15
Open
IPv777 wants to merge 20 commits intoEyesOfNetworkCommunity:masterfrom
Open
Functions listHosts/getHostById/deleteHostById working#15IPv777 wants to merge 20 commits intoEyesOfNetworkCommunity:masterfrom
IPv777 wants to merge 20 commits intoEyesOfNetworkCommunity:masterfrom
Conversation
Add functionnality to add and delete parent/child relationship
IPv777
requested review from
EyesOfNetwork,
QuentinHoarau,
davoult and
jeremyHoarau
IPv777
changed the title
Author
|
I created the functions getHostById and deleteHostById (the Nagios ID of host) |
annulation setDisplayName
ma0dubois
suggested changes
Mar 12, 2020
| $success .= "Parent added"; | ||
| } | ||
|
|
||
| if( $exportConfiguration == TRUE ) |
There was a problem hiding this comment.
No need to test a value of a boolean: if($exportConfiguration)
is enough isn't it?
|
|
||
| return true; | ||
|
|
||
| return $this->listNagiosObjects("hosts")["default"]; |
There was a problem hiding this comment.
I would add a defense on the "default" key, in the doubt that the returned array is empty.
| $error.= "That parent relationship does not exist yet.\n"; | ||
| } | ||
|
|
||
| if( $exportConfiguration == TRUE ) |
There was a problem hiding this comment.
No need to test a value of a boolean: if($exportConfiguration)
is enough isn't it?
added 2 commits
May 4, 2020 11:34
…napi into EyesOfNetworkCommunity-master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created the function listHosts to return all the hosts of Nagios