Skip to content

I have many useful changes in this branch now, feel free to cherry pick whatever you want#99

Open
intangir wants to merge 18 commits intoExultant:masterfrom
intangir:intangir
Open

I have many useful changes in this branch now, feel free to cherry pick whatever you want#99
intangir wants to merge 18 commits intoExultant:masterfrom
intangir:intangir

Conversation

@intangir
Copy link
Contributor

better fire protection
better lava protection
better for the 1.4.6 item removal issue i mentioned in another thread on cancelled messages
logging of reinforcement breaks to preciousstones snitches
tools are damaged when breaking reinforced blocks even if the block doesnt break

i made a priority change that probably has no difference for you, it was to improve compatibility with a mod you don't use

(also some housekeeping on files that i didn't want in my branch)

intangir and others added 8 commits January 2, 2013 20:47
Conflicts:

	src/com/untamedears/citadel/listener/BlockListener.java
A more elegant and simple fix for the item removal issue that appeared with 1.4.6
Log protected block breaks on snitch block even if they still have reinforcement left
Damage tools when they are used on protected blocks
@ttk2
Copy link
Collaborator

ttk2 commented Jan 15, 2013

Cool, Cool, I will have Erocs review the pull just because he has been doing maintenance then merge it and put it up for a short testing before placing it online. Thanks for your work man.

@intangir
Copy link
Contributor Author

Some of these changes may not be ideal as is for civcraft
The tool damaging one adds a lot of expense to breaking things, it works out well on my server because they can be repaired and people don't have 20 tick dro vaults ;) but civcraft is another story

removing diamond tools from the damaged list might be prudent

@erocs
Copy link
Contributor

erocs commented Jan 15, 2013

I made some quick comments, likely more as notes to myself. I like the tool damage, but it may need some adjustment for Civcraft. Thanks!

@intangir
Copy link
Contributor Author

Ya there is already rioting over it, might want to exclude damage to diamond

@intangir
Copy link
Contributor Author

I added a new feature that you probably wont want on civcraft, but its pretty cool nonetheless

a default level of protection, "by hand" protection, (uses material 'air' hehe)
it also auto bypasses your own 'by hand' protections
allows reinforcement without issue
you can change group on them too
it also auto removes by hand protection when they are pushed by a piston

i also added a feature to allow hiding of /ctinfo information if your using it on blocks you don't have access to

they can be left off, or turned on based on configuration options
shouldn't effect anything if you leave the features off

@erocs
Copy link
Contributor

erocs commented Feb 22, 2013

For the "by hand" protection, it looks like a free low-grade low-annoyance reinforcement, correct? Pretty cool. We'll have to ask ttk2 but I'm suspecting he won't want to enable it.

We should cherry-pick ed25241, for the /ctinfo change.

@ttk2
Copy link
Collaborator

ttk2 commented Feb 22, 2013

We already add nearly 60,000 reinforcements per day there is no reason to
increase that.
On Feb 22, 2013 12:13 PM, "erocs" notifications@github.com wrote:

For the "by hand" protection, it looks like a free low-grade low-annoyance
reinforcement, correct? Pretty cool. We'll have to ask ttk2 but I'm
suspecting he won't want to enable it.

We should cherry-pick ed25241ed25241,
for the /ctinfo change.


Reply to this email directly or view it on GitHubhttps://github.com//pull/99#issuecomment-13960322.

@intangir
Copy link
Contributor Author

might want to include it anyway and leave the option off for civcraft

if the mod is publicly released it is a good idea to offer more options

the reason i wanted it is because im having a hard time keeping new players, even harder when before they learn how to protect their things they are all burned down or griefed

the free protection prevents burning

also i made a quick youtube video explaining the basics of citadel usage since so few of my newer players ever bother to reinforce their stuff.., it didnt help though ;)

i can link it later (dont have access to youtube at work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants