Open
Conversation
Camillarhi
requested changes
Oct 14, 2025
Collaborator
|
Aside from the comment above, it LGTM |
Collaborator
Author
|
@Camillarhi any action on this? |
Collaborator
Author
|
@Camillarhi can you confirm this is clear? |
Collaborator
Yes, this is clear, just need to resolve the conflicts |
zealsham
reviewed
Dec 2, 2025
Comment on lines
+102
to
+109
| // pub async fn get_credential_required(&self, id: &str) -> ServiceResult<Credential> { | ||
| // let repo = CredentialRepository::new(self.pool); | ||
| // let credential = repo | ||
| // .get_credential_by_id(id) | ||
| // .await? | ||
| // .ok_or_else(|| ServiceError::not_found("Credential", id))?; | ||
| // Ok(credential) | ||
| // } |
There was a problem hiding this comment.
what is the rational behind commenting out these like of code rather than deleting them ?
Collaborator
Author
There was a problem hiding this comment.
this PR is in progress and some edit can still be made and yeah it will be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Soft Delete from Credentials Table
Changes
is_deletedanddeleted_atcolumns from credentials tabledelete_credential()from soft delete (UPDATE) to hard delete (DELETE)is_deleted = 0filteringCredentialmodel to remove soft delete fieldsNext Steps
is_currentfield to track which credential is actively being viewedSecurity Improvement
✅ Credentials are now permanently deleted from database, ensuring sensitive data (macaroons, certs) cannot be recovered