Open
Conversation
Collaborator
|
@busayo-OD please can you resolve this conflict and lets get this in. @chuksys see this if we can merge it with what you are working on? or we should merge this separately? |
busayo-OD
force-pushed
the
unit-tests
branch
2 times, most recently
from
ae922e4 to
f5bb4c9
Compare
Collaborator
Author
fixed @nully0x |
Collaborator
I think we can merge this separately and this LGTM! |
Collaborator
|
Needs a rebase now though. |
chuksys
approved these changes
Nov 26, 2025
Collaborator
Author
Done. Rebased now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for utility functions in
node_managers.rs,sats_to_usd.rs,handlers_common.rs, and Lightning types. It also updates doctests ingenerate_random_string.rs, and addslib.rsfiles to expose the modules.