Conversation
jmnunezizu
approved these changes
Oct 31, 2025
|
|
||
| private void syncTable(String dbName, String tableName, boolean deleteGluePartitions, boolean verbose) | ||
| throws TException { | ||
| private void syncTable(String dbName, String tableName, boolean deleteGluePartitions, boolean syncOnlyViews, |
There was a problem hiding this comment.
Not a big deal, but if we need to keep adding options to this method, we should consider adding a SyncTableOptions class that encapsulates deleteGluePartitions, syncOnlyViews, and verbose.
patduin
reviewed
Oct 31, 2025
|
|
||
| boolean continueOnError = cmd.hasOption("continueOnError"); | ||
| boolean deleteGluePartitions = !cmd.hasOption("keep-glue-partitions"); | ||
| boolean syncOnlyViews = cmd.hasOption("sync-only-views"); |
Contributor
There was a problem hiding this comment.
should we make this a bit more flexible: sync-types=[view,table,database]
Contributor
There was a problem hiding this comment.
or just support view, table and [view,table] for both
patduin
reviewed
Oct 31, 2025
...java/com/expediagroup/apiary/extensions/gluesync/listener/service/HiveToGlueTransformer.java
Show resolved
Hide resolved
added 2 commits
November 12, 2025 17:05
patduin
reviewed
Nov 12, 2025
| options.addOption(new Option(null, "keep-glue-partitions", false, | ||
| "If true, will keep glue partitions even if there is no corresponding hive partition. If false will delete them (default: false)")); | ||
| options.addOption(new Option(null, "sync-types", true, | ||
| "Choose what table type to sync. If non specified it will be sync all table types. Example: sync-types=EXTERNAL_VIEW,MANAGED_TABLE,EXTERNAL_TABLE")); |
Contributor
There was a problem hiding this comment.
You can add the list of possible values?
added 2 commits
November 13, 2025 09:46
patduin
approved these changes
Nov 13, 2025
patduin
reviewed
Nov 13, 2025
| <include>com.amazonaws:*</include> | ||
| <include>com.expediagroup.apiary:*</include> | ||
| <include>org.apache.httpcomponents:*</include> | ||
| <include>io.micrometer:*</include> |
patduin
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
3.6.1(was3.1.1).apiary-gluesync-listenerto1.12.792(was1.12.276)apiary-gluesync-listener.apiary-gluesync-listenerCLI🔗 Related Issues