This repository was archived by the owner on Aug 2, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Fixed pom.xml and updated deprecated methods #30
Open
Derkades
wants to merge
42
commits into
Exolius:master
Choose a base branch
from
Derkades:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
92d2e7e
Organise imports
Derkades 7cb8fbc
Remove bukkit API (spigot API includes bukkit)
Derkades d590eee
Better formatting of pom.xml
Derkades 8d7983b
Remove / (why was this here in the first place?)
Derkades a2ccc89
Update to non-deprecated methods
Derkades efb7181
Ignore eclipse project files
Derkades b4bdc61
You don't need to check for command name
Derkades afc70cd
Send a message if the sender doesn't have permission
Derkades 854cc8e
Update readme
Derkades 5a625d1
Return false instead of sending message
Derkades f68ca20
Convert indentations to spaces
Derkades c1ac079
Remove unused import
Derkades 5560a25
Move return true for better readability
Derkades 48a73c7
Remove manifest file
Derkades 0c44ed3
ammmmmmounts
Derkades 3847319
Add backup prefix config option
Derkades d7aed86
Update branding
Derkades 78cd51c
Target java 8
Derkades 40096ab
Reorganising and formatting
Derkades 07f7902
Use bukkit scheduler instead of java threads
Derkades 0649b58
Move to util package
Derkades d09439e
Put comments with their options instead of together at the top of the…
Derkades da6c0f0
Compile against spigot 1.8.8
Derkades aec977a
Pom formatting and name change
Derkades 8cd7d0e
Print world names instead of world objects
Derkades a810381
Delete old 'configuring' file
Derkades 84dd638
Load config properly
Derkades 0b33edb
Bump version
Derkades 2eadd8f
Bump maven-compiler-plugin from 2.3.2 to 3.8.1
dependabot-preview[bot] 48b63dc
Merge pull request #1 from Derkades/dependabot/maven/org.apache.maven…
Derkades fd0aa8d
Upgrade to GitHub-native Dependabot
dependabot-preview[bot] 787aede
Merge pull request #2 from Derkades/dependabot/add-v2-config-file
Derkades 04fbea8
Bump maven-compiler-plugin from 3.8.1 to 3.9.0
dependabot[bot] c9f9e88
Merge pull request #3 from Derkades/dependabot/maven/org.apache.maven…
Derkades 5aef2f2
Bump maven-compiler-plugin from 3.9.0 to 3.10.0
dependabot[bot] 33646ff
Merge pull request #4 from Derkades/dependabot/maven/org.apache.maven…
Derkades 43e9b96
Bump maven-compiler-plugin from 3.10.0 to 3.10.1
dependabot[bot] 19d15d9
Bump maven-compiler-plugin from 3.10.1 to 3.11.0
dependabot[bot] 7f5311e
Bump org.apache.maven.plugins:maven-compiler-plugin (#7)
dependabot[bot] 471c240
Bump org.apache.maven.plugins:maven-compiler-plugin (#8)
dependabot[bot] 73462ca
Bump org.apache.maven.plugins:maven-compiler-plugin (#9)
dependabot[bot] f236934
Bump org.apache.maven.plugins:maven-compiler-plugin (#10)
dependabot[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: maven | ||
| directory: "/" | ||
| schedule: | ||
| interval: daily | ||
| time: "04:00" | ||
| open-pull-requests-limit: 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,55 @@ | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <groupId>com.exolius.simplebackup</groupId> | ||
| <artifactId>SimpleBackup</artifactId> | ||
| <version>1.8</version> | ||
| <build> | ||
| <sourceDirectory>src</sourceDirectory> | ||
| <resources> | ||
| <resource> | ||
| <directory>src</directory> | ||
| <filtering>true</filtering> | ||
| <excludes> | ||
| <exclude>**/*.java</exclude> | ||
| </excludes> | ||
| </resource> | ||
| </resources> | ||
| <plugins> | ||
| <plugin> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>2.3.2</version> | ||
| <configuration> | ||
| <source>1.7</source> | ||
| <target>1.7</target> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| <repositories> | ||
| <repository> | ||
| <id>spigot-repo</id> | ||
| <url>https://hub.spigotmc.org/nexus/content/repositories/snapshots/</url> | ||
| </repository> | ||
| </repositories> | ||
| <dependencies> | ||
| <!--Spigot API--> | ||
| <dependency> | ||
| <groupId>org.spigotmc</groupId> | ||
| <artifactId>spigot-api</artifactId> | ||
| <version>1.11.2-R0.1-SNAPSHOT/</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <!--Bukkit API--> | ||
| <dependency> | ||
| <groupId>org.bukkit</groupId> | ||
| <artifactId>bukkit</artifactId> | ||
| <version>1.11.2-R0.1-SNAPSHOT/</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| </dependencies> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <groupId>com.exolius.simplebackup</groupId> | ||
| <artifactId>simplebackup</artifactId> | ||
| <version>1.9.1</version> | ||
|
|
||
| <name>SimpleBackupReloaded</name> | ||
|
|
||
| <build> | ||
| <finalName>${project.name}-${project.version}</finalName> | ||
|
|
||
| <sourceDirectory>src</sourceDirectory> | ||
|
|
||
| <resources> | ||
| <resource> | ||
| <directory>src</directory> | ||
| <filtering>true</filtering> | ||
| <excludes> | ||
| <exclude>**/*.java</exclude> | ||
| </excludes> | ||
| </resource> | ||
| </resources> | ||
|
|
||
| <plugins> | ||
| <plugin> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.14.0</version> | ||
| <configuration> | ||
| <source>1.8</source> | ||
| <target>1.8</target> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
|
|
||
| <repositories> | ||
| <repository> | ||
| <id>spigot-repo</id> | ||
| <url>https://hub.spigotmc.org/nexus/content/repositories/snapshots/</url> | ||
| </repository> | ||
| </repositories> | ||
|
|
||
| <dependencies> | ||
| <!--Spigot API --> | ||
| <dependency> | ||
| <groupId>org.spigotmc</groupId> | ||
| <artifactId>spigot-api</artifactId> | ||
| <version>1.8.8-R0.1-SNAPSHOT</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| </project> | ||
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,25 @@ | ||
| package com.exolius.simplebackup; | ||
|
|
||
| import org.bukkit.Bukkit; | ||
| import org.bukkit.command.Command; | ||
| import org.bukkit.command.CommandExecutor; | ||
| import org.bukkit.command.CommandSender; | ||
|
|
||
| public class Commands implements CommandExecutor { | ||
| private SimpleBackup plugin; | ||
|
|
||
| public Commands(SimpleBackup plugin) { | ||
| private final SimpleBackup plugin; | ||
|
|
||
| public Commands(final SimpleBackup plugin) { | ||
| this.plugin = plugin; | ||
| } | ||
|
|
||
| /*------------------------------------------------------- | ||
| This is ran when the plugin command is sent by a player | ||
| --------------------------------------------------------*/ | ||
| @Override | ||
| public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) { | ||
| if (cmd.getName().equalsIgnoreCase("sbackup")) { | ||
| if (sender.hasPermission("simplebackup.use")) { | ||
| new Thread(new Runnable() { | ||
| @Override | ||
| public void run() { | ||
| plugin.doBackup(); | ||
| } | ||
| }).start(); | ||
| } | ||
| public boolean onCommand(final CommandSender sender, final Command cmd, final String label, final String[] args) { | ||
| if (sender.hasPermission("simplebackup.use")) { | ||
| Bukkit.getScheduler().runTaskAsynchronously(this.plugin, () -> Commands.this.plugin.doBackup()); | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } | ||
| return false; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're aware that returning false prints the usage message in plugin.yml, and if the player doesn't have permission, that can also be specified in the plugin.yml. Albeit he doesn't use it for the latter purpose, I don't really see the need to tell a player they don't have permission for a simple command like this (which the player shouldn't know about anyways...) Feels more like a customization thing anyways. |
||
| } | ||
| } | ||
| } | ||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh what happened here, did you like change spaces to tabs or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh woops, that's happens automatically.. I'll convert tabs back to spaces