Skip to content

Conversation

@kevinbackhouse
Copy link
Contributor

I think this is why the links on https://exiv2.org/download.html don't work. We're deleting the html/builds directory, which is where they're copied to by the downloads.sh script.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes broken download links on the exiv2.org website by preventing the deletion of the html/builds directory during the cleanup process. The issue was that the downloads.sh script copies files to this directory, but the workflow was inadvertently removing it.

  • Removes $EXIV2WEB/html/builds from the cleanup command to preserve downloaded build artifacts
  • Maintains cleanup of temporary files and the html/releases directory

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kevinbackhouse kevinbackhouse merged commit 4e863fb into Exiv2:main Aug 30, 2025
2 checks passed
@kevinbackhouse kevinbackhouse deleted the dont-delete-builds branch August 30, 2025 08:51
@kevinbackhouse kevinbackhouse linked an issue Aug 31, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download button for 2022msvc results in 404

2 participants