Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
neiljpowell
reviewed
Apr 25, 2025
neiljpowell
reviewed
Apr 25, 2025
neiljpowell
reviewed
Apr 25, 2025
neiljpowell
reviewed
Apr 25, 2025
neiljpowell
reviewed
Apr 25, 2025
neiljpowell
reviewed
Apr 25, 2025
neiljpowell
reviewed
Apr 25, 2025
neiljpowell
reviewed
Apr 25, 2025
neiljpowell
reviewed
Apr 25, 2025
neiljpowell
reviewed
Apr 25, 2025
neiljpowell
reviewed
Apr 25, 2025
neiljpowell
reviewed
Apr 25, 2025
neiljpowell
reviewed
Apr 25, 2025
neiljpowell
reviewed
Apr 25, 2025
karthikeyanjp
force-pushed
the
kp/oss-prep
branch
3 times, most recently
from
7c28ecf to
ac490af
Compare
neiljpowell
reviewed
Jun 24, 2025
neiljpowell
reviewed
Jun 24, 2025
Member
neiljpowell
left a comment
neiljpowell
left a comment
There was a problem hiding this comment.
Almost there..couple new comments + Imran's re-review.
Also, I missed this last review.. pelase update the year at the bottom of the LICENSE here
Member
Author
updated year |
neiljpowell
reviewed
Jun 25, 2025
Member
neiljpowell
left a comment
neiljpowell
left a comment
There was a problem hiding this comment.
oops.. missed a couple of old comments
karthikeyanjp
force-pushed
the
kp/oss-prep
branch
from
5b6e963 to
acf7a55
Compare
karthikeyanjp
force-pushed
the
kp/oss-prep
branch
from
acf7a55 to
af28746
Compare
neiljpowell
reviewed
Jul 24, 2025
Member
neiljpowell
left a comment
neiljpowell
left a comment
There was a problem hiding this comment.
just a tweak remaining for the problem details responses
karthikeyanjp
force-pushed
the
kp/oss-prep
branch
2 times, most recently
from
2052883 to
e37af95
Compare
karthikeyanjp
force-pushed
the
kp/oss-prep
branch
from
e37af95 to
c55fd21
Compare
Member
Author
Fixed them.. did a custom implementation similar to Golang implementation.. sample format implemented {
"type": "urn:problems:not-found",
"status": 404,
"title": "The specified resource could not be found.",
"detail": "No route found for the HTTP path",
"instance": "urn:uuid:56bf4900-ca33-47fd-a4ca-fda43a9f5cb3",
"created": "2025-07-24T21:20:24.094Z"
}
{
"type": "urn:problems:internal-server-error",
"status": 500,
"title": "An unexpected error occurred.",
"detail": "Error constructing response: test error",
"instance": "urn:uuid:d106e6aa-0762-46a0-85c9-d7e2c790874e",
"created": "2025-07-24T21:20:24.095Z"
}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added changes to Open source the project.