transport.py: Don't disable SSL cert validation#2
transport.py: Don't disable SSL cert validation#2kmurphy4 wants to merge 2 commits intoEverlaw:masterfrom
Conversation
This is basically cherry-picks podio#40. Original commit message from @gmcguire: > Allow normal SSL certificate checking > > This fixes issue podio#27. As far as I can tell api.podio.com has a perfectly valid SSL certificate. Closes https://podio.com/easyesicom/feature-roadmap/apps/bugs/items/22339.
|
I haven't tested this yet. |
|
FWIW, I'm not actually able to reproduce the issue: I made a copy of the but it seems to work just fine? kevin.murphy@us-dev-web:~$ python3.8 -m pip freeze | grep pypodio2
pypodio2 @ https://github.com/Everlaw/podio-py/archive/0.2.1+everlaw1.tar.gz
kevin.murphy@us-dev-web:~$ ./kevin.py
<pypodio2.client.Client object at 0x7fce8ee11a90> |
|
The sooner we stop using this fork the better! This seems like a strict security improvement, so if this is working we should definitely make this change. Thanks for looking into this (or whatever the original issue was...) |
|
Do you still think we should make the change even tho i can't repro the original bug? |
|
Up to you. I'm fine with opportunistically making this change. But I think getting of podio-py is the real solution, which is pretty close to happening AFAICT. |
|
Feel free to merge if you're happy with testing, even if you can't reproduce. |
|
Idea to migrate off of this fork: https://everlaw.aha.io/ideas/ideas/EP-I-5748. |
This is basically cherry-picks podio#40.
Original commit message from @gmcguire:
Closes https://podio.com/easyesicom/feature-roadmap/apps/bugs/items/22339