intro to storymaps guide 1/4 #2440
Conversation
ManushiM
requested review from
achapkowski,
cariashuang0417,
jyaistMap,
kgalliher,
nanaeaubry,
nparavicini7 and
tarunkukreja003
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
kgalliher
left a comment
kgalliher
left a comment
There was a problem hiding this comment.
A couple of minor notes. All cells run without error.
guide/13-managing-arcgis-applications/introduction-to-storymaps.ipynb
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,893 @@ | |||
| { | |||
There was a problem hiding this comment.
I would make each number bullet a different context type so it's easier to find for users. so something like:
- Text
- Map
- ...
In addition, since this whole guide is about content I would describe what we can pass for text, what are the different TextStyles, how can users access them, see them, etc?
Reply via ReviewNB
There was a problem hiding this comment.
Thanks, I added more information about Text and TextStyles. I am not sure if splitting each content type to a separate number may help, especially since I've clubbed Map and Button with Sidecar, and Audio + Video with the intro about multimedia content. Let me know though if you feel strongly about splitting each apart.
There was a problem hiding this comment.
No that is fine you don't have to separate, just thinking about how it shows up on the navigation bar on the side. Shorter is better so users can see the topics.
Talking about this part:
| @@ -0,0 +1,893 @@ | |||
| { | |||
There was a problem hiding this comment.
StoryMap has a lot of documentation of various content. I think adding links to their documentation or copying their wording for some things can amplify the information we are providing users.
Reply via ReviewNB
There was a problem hiding this comment.
A lot of the documentation I found except for the step-by-step creation guides, was either on the developer website or in the form of learn lessons.
Do you have a doc link that differentiates Image and Image360 by any chance?
There was a problem hiding this comment.
Maybe links aren't the best but if you google each topic you can find the blogs associated with them and add some of the official doc wording. For example here: https://www.esri.com/arcgis-blog/products/arcgis-storymaps/constituent-engagement/whats-new-in-arcgis-storymaps-june-2025#360
Since this is a link to what's new in June 2025 maybe we don't link it but we can use a sentence or more from there to include here.
| @@ -0,0 +1,893 @@ | |||
| { | |||
There was a problem hiding this comment.
You are saving each time which is fine but I think considering the amount of content we are working with you might want to do this only every so often and make it like a *progress point* let's save and see what we have done so far...
TBD on this
Reply via ReviewNB
There was a problem hiding this comment.
Yeah that was my original thought, but I decided to add save() and screenshots for every section for someone who isn't running this notebook and wants to visualize what exactly is happening with each content element getting added. Happy to remove it in a few instances if that's preferred.
There was a problem hiding this comment.
Ehh let's see if others have input on this. I am on the fence as well, can be convinced either way
| @@ -0,0 +1,893 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I updated this entire Sidecar section with more context.
nanaeaubry
left a comment
nanaeaubry
left a comment
There was a problem hiding this comment.
Good first draft, but left comments where I thought more info and workflow could be added
Guide 1 of 4, the longest guide.
Closes https://github.com/ArcGIS/geosaurus/issues/12370
Checklist
Please go through each entry in the below checklist and mark an 'X' if that condition has been met. Every entry should be marked with an 'X' to be get the Pull Request approved.
imports are in the first cell?arcgisimports? Note that in some cases, for samples, it is a good idea to keep the imports next to where they are used, particularly for uncommonly used features that we want to highlight.GISobject instantiations are one of the following?gis = GIS()gis = GIS('home')orgis = GIS('pro')gis = GIS(profile="your_online_portal")gis = GIS(profile="your_enterprise_portal")./misc/setup.pyand/or./misc/teardown.py?api_data_owneruser?api_data_owneraccount and change the notebook to first download and unpack the files.<img src="base64str_here">instead of<img src="https://some.url">? All map widgets contain a static image preview? (Callmapview_inst.take_screenshot()to do so)os.path.join()? (Instead ofr"\foo\bar",os.path.join(os.path.sep, "foo", "bar"), etc.)Export Training Data Using Deep Learningtool published on geosaurus org (api data owner account) and added in the notebook usinggis.content.getfunction?gis.content.getfunction? Note: This includes providing test raster and trained model.