Offline Init Part 4 of 4: Add shared test data round-trip tests for offline initialization #119
+466
−314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part3-offline-init
branch
from
b1eab56 to
c6bb75d
Compare
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part4-shared-roundtrip-tests
branch
from
ca3c73a to
94440d2
Compare
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part3-offline-init
branch
from
c6bb75d to
a769852
Compare
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part4-shared-roundtrip-tests
branch
from
94440d2 to
1379067
Compare
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part3-offline-init
branch
from
a769852 to
b9221c2
Compare
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part4-shared-roundtrip-tests
branch
from
1379067 to
af1b3d2
Compare
This was referenced Jan 20, 2026
Open
aarsilv
changed the title
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part3-offline-init
branch
from
b9221c2 to
7cc0255
Compare
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part4-shared-roundtrip-tests
branch
from
cd66e3e to
97f3542
Compare
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part3-offline-init
branch
from
7cc0255 to
0466712
Compare
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part4-shared-roundtrip-tests
branch
from
97f3542 to
ea6a7ce
Compare
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part3-offline-init
branch
from
0466712 to
065c1b6
Compare
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part4-shared-roundtrip-tests
branch
from
ea6a7ce to
71aac8b
Compare
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part3-offline-init
branch
from
065c1b6 to
3b021c2
Compare
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part4-shared-roundtrip-tests
branch
from
71aac8b to
765ae90
Compare
Validates offline initialization using the shared UFC and bandit test data: - Initializes SDK via API, exports configuration - Resets module state and re-initializes using offlineInit - Runs all shared test cases against offline-initialized client This ensures exported configurations can be successfully used to bootstrap new SDK instances with identical behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Fixes test isolation issue where tests ran after API server was closed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ests Move offlineInit describe block inside the main 'EppoClient E2E test' block so that round-trip tests have access to the mock API server started in beforeAll. Also fix indentation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
aarsilv
force-pushed
the
aarsilv/ffesupport-461-offline-init-part4-shared-roundtrip-tests
branch
from
765ae90 to
0f2cf90
Compare
aarsilv
commented
Jan 20, 2026
| }, | ||
| ], | ||
| doLog: true, | ||
| describe('offlineInit', () => { |
Contributor
Author
There was a problem hiding this comment.
This is now pulled in to the parent E2E block so we can reuse the mock API server later on for offline init round-trip tests.
For some reason this really tripped up GitHub's diff
| }); | ||
| }); | ||
|
|
||
| describe('Shared UFC Test Cases via Offline Round-Trip', () => { |
Contributor
Author
There was a problem hiding this comment.
This is the meat of the change: using our shared test data to init normally, export the config, then offline init and run the shared test cases 💪
| ); | ||
| }); | ||
|
|
||
| describe('Shared Bandit Test Cases via Offline Round-Trip', () => { |
Contributor
Author
There was a problem hiding this comment.
And the bandit meat 💪
There was a problem hiding this comment.
Pull request overview
This PR adds round-trip tests that validate the offline initialization workflow by exporting configurations from an online-initialized client and re-importing them via offlineInit(). The tests verify that offline-initialized clients produce identical assignment results to online-initialized clients using shared test cases from the sdk-test-data repository.
Changes:
- Removed an extra closing brace that was causing a structural error
- Added round-trip tests for UFC (Universal Feature Configuration) test cases
- Added round-trip tests for Bandit test cases
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
getFlagsConfiguration()andgetBanditsConfiguration()can be successfully imported viaofflineInit()sdk-test-datarepository (UFC and Bandit test suites) to ensure offline-initialized clients produce identical assignment results to online-initialized clientsStacked PRs
getFlagsConfiguration()getBanditsConfiguration()offlineInit()Test plan
🤖 Generated with Claude Code