Skip to content

Address vulnerabilities #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aarsilv merged 2 commits into from
Jan 6, 2026
Merged

Address vulnerabilities #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe3ee29
address vulnerabilities
aarsilv Jan 6, 2026
e11db0d
address linting issues
aarsilv Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
],
"typings": "dist/node-server-sdk.d.ts",
"scripts": {
"lint": "eslint '**/*.{ts,tsx}' '**/*.d.{ts,tsx}' --cache",
"lint": "eslint '**/*.{ts,tsx}' --cache",
Copy link
Contributor Author

@aarsilv aarsilv Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No .d.ts files in this project which was causing issues using linter in some situations

"lint:fix": "eslint --fix '**/*.{ts,tsx}' --cache",
"lint:fix-pre-commit": "eslint -c .eslintrc.pre-commit.js --fix '**/*.{ts,tsx}' --no-eslintrc --cache",
"prepare": "make prepare",
Expand All @@ -33,26 +33,26 @@
},
"devDependencies": {
"@google-cloud/storage": "^7.18.0",
"@microsoft/api-documenter": "^7.23.9",
"@microsoft/api-documenter": "^7.28.2",
Copy link
Contributor Author

@aarsilv aarsilv Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that all fixes are in devDependencies

"@microsoft/api-extractor": "^7.38.0",
"@types/express": "^4.17.13",
"@types/jest": "^29.2.4",
"@types/jest": "^29.5.14",
"@typescript-eslint/eslint-plugin": "^5.13.0",
"@typescript-eslint/parser": "^5.13.0",
"eslint": "7.32.0",
"eslint": "^8.57.1",
"eslint-config-prettier": "^8.5.0",
"eslint-import-resolver-typescript": "^2.5.0",
"eslint-plugin-import": "^2.25.4",
"eslint-plugin-prettier": "^4.0.0",
"eslint-plugin-promise": "^6.0.0",
"express": "^4.21.1",
"express": "^4.22.1",
"husky": "^6.0.0",
"jest": "^29.7.0",
"lint-staged": "^12.3.5",
"prettier": "^2.2.1",
"testdouble": "^3.16.4",
"ts-jest": "^29.0.0",
"typescript": "^4.2.4"
"ts-jest": "^29.4.6",
"typescript": "^5.4.5"
},
"engines": {
"node": ">=18.x",
Expand Down
4 changes: 2 additions & 2 deletions src/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ describe('EppoClient E2E test', () => {
baseUrl: `http://127.0.0.1:${TEST_SERVER_PORT}`,
assignmentLogger: mockLogger,
});

Copy link
Contributor Author

@aarsilv aarsilv Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up unrelated leftover linting issues

// Access the internal configurationRequestParameters to verify the default
const configurationRequestParameters = client['configurationRequestParameters'];
expect(configurationRequestParameters.pollAfterSuccessfulInitialization).toBe(true);
Expand All @@ -729,7 +729,7 @@ describe('EppoClient E2E test', () => {
assignmentLogger: mockLogger,
pollAfterSuccessfulInitialization: false,
});

// Access the internal configurationRequestParameters to verify the custom value
const configurationRequestParameters = client['configurationRequestParameters'];
expect(configurationRequestParameters.pollAfterSuccessfulInitialization).toBe(false);
Expand Down
Loading