Skip to content

Add more robustness to Adonis loader boot sequence module loading #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ccuser44 wants to merge 6 commits into
base: master
Choose a base branch
from
+21 −7
Open

Add more robustness to Adonis loader boot sequence module loading #2018

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e4c22ca
Attempt to load nightly module in backup boot sequence
ccuser44 Nov 23, 2025
7deaf6f
Add support for new assert service insert method
ccuser44 Nov 23, 2025
204922c
Fix syntax error in loadModuleAsset function
ccuser44 Nov 23, 2025
94f798f
Fix formatting in loadModuleAsset function
ccuser44 Nov 23, 2025
38500fa
Add AssetService variable to Loader.server.luau
ccuser44 Nov 23, 2025
0bd7dc0
Fix typo
ccuser44 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions Loader/Loader/Loader.server.luau
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ end
local ServerScriptService = game:GetService("ServerScriptService")
local RunService = game:GetService("RunService")
local InsertService = game:GetService("InsertService")
local AssetService = game:GetService("AssetService")

-- Support yieldable xpcall
local function yxpcall(f, callback, ...)
Expand All @@ -46,7 +47,7 @@ local function yxpcall(f, callback, ...)
end

local function loadModuleAsset(moduleId: number)
local asset = InsertService:LoadAsset(moduleId)
local asset = ({yxpcall(function() return nil, AssetService:LoadAssetAsync(moduleId) end, warn)})[3] or InsertService:LoadAsset(moduleId)

if asset.Name == "MainModule" then
return assert(require(asset), ":LoadAsset() module returned invalid values!")
Expand Down Expand Up @@ -203,18 +204,31 @@ else
module = loadModuleAsset(moduleId)
success = true
end, function(reason)
warn(`Failed to load Adonis mainmodule {moduleId} via :LoadAsset() method due to {reason}! Loading the backup MainModule...`)
warn(`Failed to load Adonis mainmodule {moduleId} via :LoadAsset() method due to {reason}! Loading the nightly MainModule...`)
local newModuleId = not data.NightlyMode and data.NightlyModuleID or data.ModuleID
yxpcall(function()
module = assert(require(data.Backup), "Backup module returned invalid values!")
module = assert(require(newModuleId), "Nightly module returned invalid values!")
success = true
end, function(reason)
warn(`Failed to load Adonis backup MainModule {data.Backup} due to {reason}! If this does not work please purchase the Adonis backup MainModule to your inventory. Using backup method...`)
warn(`Failed to load Adonis nightly MainModule {newModuleId} due to {reason}! If this does not work please purchase the Adonis nightly MainModule to your inventory. Using backup method...`)
yxpcall(function()
module = loadModuleAsset(data.Backup)
module = loadModuleAsset(newModuleId)
success = true
end, function(reason)
module = nil
warn(`FATAL ERROR! Failed to load Adonis backup MainModule {moduleId} via :LoadAsset() method due to {reason}! Adonis can't be booted up! Please contact the Adonis helpers immediately and add both the regular MainModule and the backup MainModule to your user&group inventory!`)
warn(`Failed to load Adonis nightly mainmodule {newModuleId} via :LoadAsset() method due to {reason}! Loading the backup MainModule...`)
yxpcall(function()
module = assert(require(data.Backup), "Backup module returned invalid values!")
success = true
end, function(reason)
warn(`Failed to load Adonis backup MainModule {data.Backup} due to {reason}! If this does not work please purchase the Adonis backup MainModule to your inventory. Using backup method...`)
yxpcall(function()
module = loadModuleAsset(data.Backup)
success = true
end, function(reason)
module = nil
warn(`FATAL ERROR! Failed to load Adonis backup MainModule {moduleId} via :LoadAsset() method due to {reason}! Adonis can't be booted up! Please contact the Adonis helpers immediately and add both the regular MainModule and the backup MainModule to your user&group inventory!`)
end)
end)
end)
end)
end)
Expand Down
Loading