Skip to content

update buck2 samples using https://github.com/facebook/buck2/pull/826#372

Merged
nlopezgi merged 16 commits intomainfrom
nlopezgi/cleanUpBuck2Samples
Mar 4, 2025
Merged

update buck2 samples using https://github.com/facebook/buck2/pull/826#372
nlopezgi merged 16 commits intomainfrom
nlopezgi/cleanUpBuck2Samples

Conversation

@nlopezgi
Copy link
Contributor

  • Use constraints to select action keys for tests on RE only
  • Use --target-platforms to select platform on the command line
  • Remove RE only attrs from targets

@nlopezgi nlopezgi force-pushed the nlopezgi/cleanUpBuck2Samples branch from 7c7b376 to a12e83b Compare February 26, 2025 18:08
@nlopezgi nlopezgi changed the title update buck2 samples according to recommendations in rust2 sample PR update buck2 samples using https://github.com/facebook/buck2/pull/826 Feb 26, 2025
@nlopezgi nlopezgi force-pushed the nlopezgi/cleanUpBuck2Samples branch from 23c308b to 6576ccc Compare March 3, 2025 14:45
@nlopezgi nlopezgi requested a review from TheGrizzlyDev March 3, 2025 14:51
@nlopezgi nlopezgi merged commit 1fb2b93 into main Mar 4, 2025
5 checks passed
@nlopezgi nlopezgi deleted the nlopezgi/cleanUpBuck2Samples branch March 4, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants