Conversation
7773cd7 to
86e0d6d
Compare
40e2a0c to
03772a8
Compare
TheGrizzlyDev
left a comment
There was a problem hiding this comment.
You're using rbe as a target platform instead of an exec platform, which isn't quite accurate, is there a way to tell buck2 it's an exec platform instead?
this comment is still pending, you're incorrectly using target platforms. You aren't targetting RBE, you're using it to run actions. |
Apologies I had missed it.
Let me know if you prefer to have the |
There was a problem hiding this comment.
This whole file is oddly formatted, can you please fix it?
There was a problem hiding this comment.
Not sure which bit exactly you find has the odd formatting.
The only clear think I could see is the use of spaces in some of the section entries. I removed some of the spaces in the sections. However, it seems to me there is a mix in other .buckconfig files of the use of space for entries in secions or no spaces. See for example: https://github.com/facebook/buck2/blob/main/examples/with_prelude/.buckconfig and examples in https://buck2.build/docs/concepts/buckconfig/#configuration-files-can-include-other-files that do have the leading spaces in the entries.
Let me know if it was something else that you found odd about the formatting.
Uh oh!
There was an error while loading. Please reload this page.