[WIP] Manage IPA groups and IPA group memberships#11
Open
[WIP] Manage IPA groups and IPA group memberships#11
Conversation
bishopbm1
approved these changes
Jan 26, 2021
Member
Author
|
@bishopbm1 wait for this until the tests are passing |
Contributor
|
yea i saw thats why i didn't merge yet. Changes looked good though! |
Member
Author
|
@bishopbm1 i got tests to pass, keep holding on this, i want to add new unit tests please |
nmaludy
changed the title
nmaludy
force-pushed
the
feature/ipa-groups
branch
from
4a24c55 to
620109e
Compare
…e is already managed
paxri01
approved these changes
Feb 25, 2021
paxri01
left a comment
paxri01
left a comment
There was a problem hiding this comment.
Looks good to me, can't comment much on ruby scripts.
|
Also note, will need to update README.txt with user/group changes. |
nmaludy
force-pushed
the
feature/ipa-groups
branch
from
25f1ade to
0eee490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.