You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, won't go too in-depth in this review unless I know you'll see this, if you do please respond with a comment. I don't want to waste time reviewing a chart that I don't know will be fixed, respectfully
So possibly major issue-
There seems to be duplicate track names for Classic and Pad, so there's a PART DRUMS with pad charting and a PART DRUMS with standard rock band charting, I'm not sure how well the game handles this so please remove the PART track names with the charting from Moonscraper(?)
You're missing the [music_end] and [end] events in your EVENTS track, at [music_end] where either the music ends or where you would want the crowd to begin cheering in something like rock band, and [end] when you want the game to go to the score screen.
On pad vocals there are really minor pitch errors, and some patterns should be adjusted to be played with both hands instead of one hand on the right/left side of the highway
There may be minor pitch accuracy errors on both bass charts, mainly in the chorus
There are no drum fill makers on classic drums, meaning the player can't activate overdrive
Otherwise I don't exactly see much issue with everything else, though you should add your charter credits in info.json and I think you have your intensity ratings (the difficulty rating) setup wrong. I'd also chart easier difficulties for Pad Vocals just so it's full controller band all difficulties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chart Verification PR
Stars - Look Away
Instruments and difficulties charted
Additional details