Skip to content

Comments

Upgrade to net10#181

Merged
MarioEncamina merged 94 commits intomainfrom
upgrade-to-NET10
Dec 16, 2025
Merged

Upgrade to net10#181
MarioEncamina merged 94 commits intomainfrom
upgrade-to-NET10

Conversation

@MarioEncamina
Copy link
Collaborator

Description

This pull request upgrades the solution from .NET 8.0 to .NET 10.0 and updates all related dependencies and sample projects accordingly.

Type of change

Please check only those options that are relevant with a (✅).

  • [✅] The code builds clean without any errors or warnings
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Please check all options from this checklist when validating your pull request with a (✅).

  • [✅] My code follows the style guidelines of this project
  • [✅] I have performed a self-review of my own code
  • [✅] I have commented my code, particularly in hard-to-understand areas
  • [✅] I have made corresponding changes to the documentation
  • [✅] My changes generate no new warnings
  • [✅] Any dependent changes have been merged and published in downstream modules
  • [✅] I didn't break anyone 😄

Removed redundant PropertyGroup, keeping only necessary properties such as TargetFramework and PackageReadmeFile in the project file.
Upgraded Microsoft.Extensions.DependencyInjection.Abstractions to version 10.0.1 and removed the System.ComponentModel.Annotations package reference from the project file.
Merged two PropertyGroup sections into one in Encamina.Enmarcha.Core.csproj, consolidating project properties for improved organization and maintainability. No functional changes were made.
Upgraded package references in Encamina.Enmarcha.Core.csproj:
- Microsoft.Extensions.Configuration.Abstractions updated from 8.0.0 to 10.0.1
- System.Configuration.ConfigurationManager updated from 8.0.1 to 10.0.1
- System.Text.Json updated from 8.0.5 to 10.0.1
Removed System.ComponentModel.Annotations package reference.
…neric to ensure that predefined types like System.Object, ICollection<T>, and IEnumerable<T> are available.' en el archivo 'src\Encamina.Enmarcha.Core\Extensions\ICollectionExtensions.cs'
…that nullable reference types and related attributes are available, which can help resolve missing predefined types like 'System.Object'. This is a common step per CS0518 documentation. If the error persists, the issue may be with the project or SDK setup rather than the code file.' en el archivo 'src\Encamina.Enmarcha.Core\Extensions\ICollectionExtensions.cs'
…sure that core .NET types like System.Object are available, as missing references to core assemblies can cause CS0518. This is a common workaround for this error.' en el archivo 'src\Encamina.Enmarcha.Core\Extensions\ICollectionExtensions.cs'
…paces (System, System.Collections.Generic) are included first, which can help the compiler resolve predefined types like System.Object. This is a common step to address CS0518 when the project setup is otherwise correct.' en el archivo 'src\Encamina.Enmarcha.Core\Extensions\ICollectionExtensions.cs'
Removed an unnecessary PropertyGroup from the project file, consolidating properties for improved clarity and maintainability. No functional changes to the build process.
Changed the target framework in Encamina.Enmarcha.Net.Http.csproj from net8.0 to net10.0 to support newer .NET features and improvements. No other changes were made to the project file.
- Upgraded Microsoft.Extensions.DependencyInjection.Abstractions package from version 8.0.2 to 10.0.1 in Encamina.Enmarcha.DependencyInjection.csproj.
- Changed target framework from net8.0 to net10.0 in Encamina.Enmarcha.Net.Http.csproj.
Updated Microsoft.Extensions.Options to version 10.0.1 and removed System.ComponentModel.Annotations from Encamina.Enmarcha.AI.Abstractions.csproj. Also cleaned up redundant PropertyGroup entries in Encamina.Enmarcha.AI.TextsTranslation.Abstractions.csproj. No functional code changes were made.
…a.Enmarcha.Entities.csproj

Upgraded the Microsoft.Extensions.Logging.Abstractions NuGet package from version 8.0.3 to 10.0.1 in the Encamina.Enmarcha.Entities.csproj file to ensure compatibility with newer dependencies and receive the latest features and fixes. No other changes were made.
Reorganized property and item groups in the project file for improved clarity. Moved package references and the README inclusion into a single <ItemGroup>, and removed redundant or empty property and item groups. No changes to dependencies or functionality.
…a.Enmarcha.Conversation.csproj

Upgraded the Microsoft.Extensions.Caching.Abstractions NuGet package from version 8.0.0 to 10.0.1 in the Encamina.Enmarcha.Conversation.csproj file to ensure compatibility with newer dependencies and receive the latest features and fixes. No other changes were made.
Changed the target framework in Encamina.Enmarcha.Agents.Abstractions.csproj from net8.0 to net10.0, ensuring the project now targets the latest .NET version. No other changes were made.
Consolidated property and item groups in Encamina.Enmarcha.AI.csproj by removing redundant <PropertyGroup> and <ItemGroup> sections, streamlining the project file structure without affecting dependencies or functionality.
Upgraded Microsoft.Extensions.Options from 8.0.2 to 10.0.1 and System.Numerics.Tensors from 8.0.0 to 10.0.1 in the Encamina.Enmarcha.AI.csproj file. No other changes were made.
Merged property groups in the project file by moving the PackageReadmeFile property into the main PropertyGroup, removing a redundant PropertyGroup declaration. No functional changes were made.
…proj

Upgraded several Microsoft.Extensions.* package references to version 10.x and updated Microsoft.Extensions.Azure to 1.13.1. Removed the System.ComponentModel.Annotations package reference. These changes ensure compatibility with newer dependencies and streamline the project's package requirements.
…l.csproj

Changed the target framework in Encamina.Enmarcha.SemanticKernel.csproj from net6 to net10.0 to support newer .NET features and improvements. No other modifications were made.
Upgraded Microsoft.Extensions.Hosting, Microsoft.Extensions.Options.ConfigurationExtensions, and Microsoft.Extensions.Options.DataAnnotations package references from version 8.x to 10.0.1 in the Encamina.Enmarcha.SemanticKernel.csproj file. No other changes were made.
Removed an unnecessary PropertyGroup from Encamina.Enmarcha.Email.Abstractions.csproj, consolidating project properties for improved clarity and maintainability. No functional changes were made.
Changed the target framework from net8.0 to net10.0 in the Encamina.Enmarcha.Agents.csproj project file to support newer .NET features and improvements. No other changes were made.
…zure.csproj

Consolidated multiple <PropertyGroup> sections into one in the Encamina.Enmarcha.AI.QuestionsAnswering.Azure.csproj file, removing redundant groupings and improving project file organization. No changes to build or functionality.
Upgraded several Microsoft.Extensions.* package references in Encamina.Enmarcha.AI.QuestionsAnswering.Azure.csproj from version 8.x to 10.0.1, including Caching.Abstractions, Configuration.Abstractions, Hosting, Options.ConfigurationExtensions, and Options.DataAnnotations. Other package references remain unchanged. This update ensures compatibility with newer .NET libraries and features.
Removed an unnecessary PropertyGroup from the project file, consolidating properties for improved clarity and maintainability. No functional changes were made.
Upgraded several Microsoft.Extensions.* and System.Net.Http.Json package references from version 8.x to 10.0.1 in Encamina.Enmarcha.AI.LanguagesDetection.Azure.csproj to ensure compatibility with newer dependencies and receive the latest features and fixes.
…ure.csproj

Merged separate PropertyGroup elements into one and removed redundant PropertyGroup, streamlining the project file structure. No changes to build targets or package metadata.
Upgraded Microsoft.Extensions.* package references in Encamina.Enmarcha.AI.IntentsPrediction.Azure.csproj from version 8.x to 10.0.1, ensuring compatibility with newer dependencies and features. No other changes were made.
Deleted the System.Linq.Async package from both Encamina.Enmarcha.SemanticKernel and Encamina.Enmarcha.SemanticKernel.Plugins.Memory project files as it is no longer required.
Updated global.json to use .NET SDK version 10.0.100 and documented the upgrade in CHANGELOG.md under Major Changes.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request attempts to upgrade the Encamina.Enmarcha solution from .NET 8.0 to .NET 10.0, updating all project files, package references, and the global SDK configuration. The upgrade involves updating over 50 projects across test, source, and sample directories.

Key changes:

  • Updated global.json SDK version from 8.0.100 to 10.0.100
  • Upgraded target framework from net8.0/net6.0 to net10.0 for non-netstandard projects
  • Updated Microsoft.Extensions.* packages to version 10.0.1
  • Removed System.Linq.Async from projects targeting net10.0 (kept for netstandard2.1)
  • Replaced Aspire.Hosting 8.2.2 with Aspire.Hosting.AppHost 13.0.2
  • Consolidated PropertyGroup elements in multiple .csproj files

Reviewed changes

Copilot reviewed 54 out of 54 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
global.json Updated SDK version to 10.0.100
Directory.Build.props Removed version suffix (preview-09)
CHANGELOG.md Added entry documenting .NET 10.0 upgrade
.github/upgrades/dotnet-upgrade-plan.md New file documenting detailed upgrade plan and package changes
tst/*.csproj (8 files) Updated TargetFramework to net10.0 and package versions to 10.0.1
src/*.csproj (32 files) Updated TargetFramework and/or package versions; consolidated PropertyGroups
samples/*.csproj (3 files) Updated TargetFramework to net10.0 and package versions
src/Encamina.Enmarcha.Core/Extensions/ICollectionExtensions.cs Added explicit using statements for System and System.Collections.Generic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Upgraded Microsoft.SemanticKernel and related packages to version 1.66.0 across multiple projects for improved compatibility and features. Also updated System.Drawing.Common to 10.0.1 in Document connector. Changelog updated to reflect these changes.
borjapdc
borjapdc previously approved these changes Dec 11, 2025
Replaces System.Linq.Async v6.0.1 with System.Linq.AsyncEnumerable v10.0.1 in both AI.QuestionsAnswering.Azure and Conversation projects. Also updates method calls to use the new cancellationToken parameter syntax for compatibility with the updated package.
Bumped Swashbuckle.AspNetCore.Annotations package from version 8.0.0 to 10.0.1 to ensure compatibility with latest features and bug fixes.
Copy link
Member

@rliberoff rliberoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file dotnet-upgrade-plan.md is a leftover, isn't it?

@MarioEncamina
Copy link
Collaborator Author

I think this file dotnet-upgrade-plan.md is a leftover, isn't it?

U're right! deleted

Copy link
Member

@rliberoff rliberoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarioEncamina MarioEncamina merged commit ac3cb41 into main Dec 16, 2025
2 checks passed
@MarioEncamina MarioEncamina deleted the upgrade-to-NET10 branch December 16, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants