Pandas and time zone (tz) info. #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@simongarisch happy to merge once tests past. Looks like the test is still failing right now. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there.
The current version of pandas throws an error when comparing trading_days (with tz=UTC) to a standard python datetime with no tz info. Basically, it wants the time zone info to be consistent. I've added a few minor changes to make this work.
It also looks like the data coming back for the test file is slightly different. I've modified expected return values slightly, so have a quick look and let me know what you think. The tests should now be passing.
Pandas is also grumbling a touch about Panel => FutureWarning: Panel is deprecated and will be removed in a future version. Perhaps it'd be better to specify a particular pandas version in requirements.txt rather than pandas>=0.17.0... always tough with the Pandas deprecations.
Cheers,
Simon.